Skip to content

libfdt: problems with real life blobs

Jerry Van Baren linuxppc-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2libfdt: Make the test values fdt endiantests/del_node.c tests/del_property.c tests/find_property.c +9 more+34 -350 replies
2/2libfdt: Use Jon's fdc for testingtests/Makefile tests/test_tree1.dts+31 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] libfdt: problems with real life blobs

Hi David,

I've been trying to use your libfdt in u-boot and my first step, get a value from the blob, failed terminally. After poking about a bit, it appears that your libfdt and Jon Loeliger's dtc (-V 16) disagree with respect to the format of the blob - libfdt won't traverse the path.

I've created two patches:
1) Make the libfdt tests use "fdt endian" so that dtc can be used.
2) Create a minimal test tree and compile it with dtc.

The first patch is clean, the second patch is a bit of a hack job, I did just enough to check this out and confirm/deny my suspicions that libfdt doesn't like the dtc format. Running the tests on the dtc-compiled blob shows the same problems with traversing paths.

I think I created the correct tree in test_tree1.dts (I didn't do the truncated node, but that is immaterial for my primary objective) but I could be wrong...

Supporting using dtc in the long run as well as the assembly-generated blob would be nice so that regression tests can be done on different versions of the blob format (both supported and unsupported) and to make sure libfdt and dtc stay in sync.

Best regards,
gvb