Skip to content

nfs-utils : fix some bugs of umount.nfs

Wei Yongjun linux-nfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4Use correct UMNT version to do umountmount/nfsumount.c+6 -12 replies
2/4Fix nfs4 umount to not used umount proceduremount/nfsumount.c+12 -271 reply
3/4Use correct UMNT protocol to do umountmount/nfsumount.c+27 -241 reply
4/4Rename add_mtab2() to del_mtab()mount/nfsumount.c+3 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] nfs-utils : fix some bugs of umount.nfs

This patch series has 4 patches to fix some bugs of umount.nfs command.

[PATCH 1/4]  Use correct UMNT version to do umount
[PATCH 2/4]  Fix nfs4 umount to not used umount procedure
[PATCH 3/4]  Use correct UMNT protocol to do umount
[PATCH 4/4]  Rename add_mtab2() to del_mtab()

These is also some work to do with umount.nfs, such as following:

1. getmntdirbackward() does not free the memory it malloc, which may cause memory leak, also can be found it my patch.

2. If file /proc/mounts it wasn't found and we can not found mount entry in /etc/mtab(it has been removed from this file), umount will fail with message "umount: %s: not found"

3. If the server is down, we can not umount an nfs filesystem, I can make a patch, but I don't know if the server is down, do we have permission to umount? Can umount fail from remote server because of permission problem?

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs