Make common helpers for seq_files that work with list_head-s (v2)
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest15 patches 4 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/15 | The helper functions itselvesfs/ include/ | +45 | 1 reply | |
| 2/15 | Make AFS use seq_list_xxx helpersfs/ | +11 | 0 replies | |
| 3/15 | Make ATM driver use seq_list_xxx helpersnet/ | +4 | 0 replies | |
| 4/15 | Make block layer /proc files use seq_list_xxx helpersblock/ | +14 | 0 replies | |
| 5/15 | Make crypto API use seq_list_xxx helperscrypto/ | +3 | 1 reply | |
| 6/15 | Make input layer use seq_list_xxx helpersdrivers/ | +4 | 0 replies | |
| 7/15 | Make ISDN CAPI use seq_list_xxx helpersdrivers/ | +4 | 0 replies | |
| 8/15 | Make /proc/misc use seq_list_xxx helpersdrivers/ | +3 | 0 replies | |
| 9/15 | Make /proc/modules use seq_list_xxx helperskernel/ | +2 | 0 replies | |
| 10/15 | Make some network-related proc files use seq_list_xxx helpersnet/ net/ | +10 | 1 reply | |
| 11/15 | Make some netfilter-related proc files use seq_list_xxx helpersnet/ net/ | +8 | 0 replies | |
| 12/15 | Make NFS client use seq_list_xxx helpersfs/ | +6 | 1 reply | |
| 13/15 | Make /proc/tty/drivers use seq_list_xxx helpersfs/ | +3 | 0 replies | |
| 14/15 | Make /proc/slabinfo use seq_list_xxx helpersmm/ | +5 | 0 replies | |
| 15/15 | Make /proc/self/mounts(tats) use seq_list_xxx helpersfs/ | +5 | 0 replies |
Reviews trailers per patch
2 of 15 patches have a Reviewed-by or Acked-by.
| Patch | David S. Miller | Trond Myklebust |
|---|---|---|
| 1/15 | ||
| 2/15 | ||
| 3/15 | ||
| 4/15 | ||
| 5/15 | ||
| 6/15 | ||
| 7/15 | ||
| 8/15 | ||
| 9/15 | ||
| 10/15 | A-b | |
| 11/15 | ||
| 12/15 | A-b | |
| 13/15 | ||
| 14/15 | ||
| 15/15 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/15] Make common helpers for seq_files that work with list_head-s (v2)
Many places in kernel use seq_file API to iterate over a regular list_head. The code for such iteration is identical in all the places, so it's worth introducing a common helpers.
This makes code about 300 lines smaller:
block/genhd.c | 40 +++----- crypto/proc.c | 17 --- drivers/char/misc.c | 18 ---- drivers/input/input.c | 29 ------ drivers/isdn/capi/kcapi_proc.c | 28 ------ fs/afs/proc.c | 81 ++---------------- fs/namespace.c | 14 --- fs/nfs/client.c | 54 +----------- fs/proc/proc_tty.c | 15 --- fs/seq_file.c | 34 +++++++ include/linux/seq_file.h | 11 ++ kernel/module.c | 17 --- mm/slab.c | 28 +----- net/atm/br2684.c | 22 ---- net/core/sock.c | 39 -------- net/ipv4/netfilter/nf_conntrack_l3proto_ipv4_compat.c | 27 ------ net/netfilter/nf_conntrack_expect.c | 27 ------ net/rxrpc/ar-proc.c | 48 +--------- 18 files changed, 126 insertions(+), 423 deletions(-)
The first version of this patch made the helper functions static inline in the seq_file.h header. This patch moves them to the fs/seq_file.c as Andrew proposed. The vmlinux .text section sizes are as follows:
2.6.22-rc1-mm1: 0x001794d5 with the previous version: 0x00179505 with this patch: 0x00179135
The config file used was make allnoconfig with the "y" inclusion of all the possible options to make the files modified by the patch compile plus drivers I have on the test node.