Skip to content

Resurrect sdev during scanning

Hannes Reinecke linux-scsi 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9Add scsi_destroy_device()drivers/scsi/scsi_scan.c include/scsi/scsi_device.h+7 -20 replies
2/9Improve error messages in scsi_sysfs_add_sdev()drivers/scsi/scsi_sysfs.c+4 -20 replies
3/9Remove stale put_device() from scsi_sysfs_add_sdev()drivers/scsi/scsi_sysfs.c+0 -10 replies
4/9Free sdev class device from release functiondrivers/scsi/scsi_scan.c drivers/scsi/scsi_sysfs.c+22 -250 replies
5/9Fixup LLDDs to check for valid hostdata pointerdrivers/message/fusion/mptscsih.c drivers/s390/scsi/zfcp_scsi.c drivers/scsi/53c700.c +3 more+17 -101 reply
6/9Implement scsi_configure_device()drivers/scsi/scsi_scan.c+44 -180 replies
7/9Remove obsolete scsi_destroy_sdev() functiondrivers/scsi/scsi_scan.c+0 -80 replies
8/9Implement scsi_resurrect_device()drivers/scsi/scsi.c drivers/scsi/scsi_lib.c drivers/scsi/scsi_scan.c+56 -10 replies
9/9Leftoversdrivers/scsi/scsi_scan.c+1 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/9] Resurrect sdev during scanning

Hi James,

this is a patchset to address the outstanding 'sdev oops during scanning' issue. Problem is that any sdev in state 'SDEV_DEL' is still visible to the host until the refcount drops to zero. When a scan occurs during this time we access a half-initialized sdev and all hell breaks loose.

So to address this issue this patchset implements a 'scsi_resurrect_device()' function which will put an sdev in state SDEV_DEL back to SDEV_RUNNING, thus allowing normal operations again. In doing so I also had to clean up the sdev allocation and removal a bit so that we're now more aligned to the state machine and the driver core's device_initialize / device_add logic.

The entire patchset has been tested quite heavily with SLES10 SP1.

Comments etc. welcome.

Otherwise, please apply.

Cheers,

Hannes

Signature · 8 lines
Dr. Hannes Reinecke		      zSeries & Storage
[email protected]			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html