Skip to content

fbdev: Fix palette handling in various drivers

Antonino A. Daplas linux-fbdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest21 of 24 patches 9 repliesIn review

21 of 24 patches are in this archive. The cover letter announces 24.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2468328fb: The pseudo_palette is only 16 elements longdrivers/video/68328fb.c+1 -10 replies
2/24controlfb: The pseudo_palette is only 16 elements longdrivers/video/controlfb.c+1 -11 reply
3/24cyblafb: Fix pseudo_palette array overrun in setcolregdrivers/video/cyblafb.c+12 -90 replies
4/24epson1355fb: Color setting fixesdrivers/video/epson1355fb.c+3 -20 replies
5/24ffb: The pseudo_palette is only 16 elements longdrivers/video/ffb.c+2 -22 replies
6/24fm2fb: The pseudo_palette is only 16 elements longdrivers/video/fm2fb.c+9 -71 reply
7/24gbefb: The pseudo_palette is only 16 elements longdrivers/video/gbefb.c+21 -200 replies
8/24macfb: Fix pseudo_palette size and overrundrivers/video/macfb.c+50 -430 replies
9/24offb: The pseudo_palette is only 16 elements longdrivers/video/offb.c+1 -11 reply
10/24platinumfb: The pseudo_palette is only 16 elements longdrivers/video/platinumfb.c+1 -10 replies
11/24pvr2fb: Fix pseudo_palette array overrun and typecastdrivers/video/pvr2fb.c+4 -31 reply
13/24sgivwfb: The pseudo_palette is only 16 elements longdrivers/video/sgivwfb.c+1 -10 replies
14/24sunxvr2500fb: Fix pseudo_palette array sizedrivers/video/sunxvr2500.c+8 -90 replies
17/24tridentfb: Fix pseudo_palette array overrun in setcolregdrivers/video/tridentfb.c+16 -140 replies
18/24tx3912fb: Fix improper assignment of info->pseudo_palettedrivers/video/tx3912fb.c+1 -10 replies
19/24atyfb: The pseudo_palette is only 16 elements longdrivers/video/aty/atyfb_base.c+1 -10 replies
20/24radeonfb: The pseudo_palette is only 16 elements longdrivers/video/aty/radeonfb.h+1 -10 replies
21/24i810fb: The pseudo_palette is only 16 elements longdrivers/video/i810/i810.h+1 -10 replies
22/24intelfb: The pseudo_palette is only 16 elements longdrivers/video/intelfb/intelfb.h+1 -10 replies
23/24matroxfb: Color setting fixesdrivers/video/matrox/matroxfb_base.c drivers/video/matrox/matroxfb_base.h drivers/video/matrox/matroxfb_crtc2.h+6 -23 replies
24/24sisfb: Fix pseudo_palette array size and overrundrivers/video/sis/sis.h drivers/video/sis/sis_main.c+7 -10 replies

Reviews trailers per patch

4 of 21 patches have a Reviewed-by or Acked-by.

PatchBenjamin HerrenschmidtGeert UytterhoevenPaul Mundt
1/24
2/24A-b
3/24
4/24
5/24
6/24A-b
7/24
8/24
9/24A-b
10/24
11/24A-b
13/24
14/24
17/24
18/24
19/24
20/24
21/24
22/24
23/24
24/24

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/24] fbdev: Fix palette handling in various drivers

The bug described here:

http://lkml.org/lkml/2007/5/27/104

resulting from improper palette handling in neofb prompted me to audit the palette handling in various drivers. Most of the problems are over-allocating memory for the palette (not really a problem, just wastes memory) but a few have bugs similar to the one described above.

Andrew,

(Since I can only compile test some of them, you can keep them in -mm for a while).

Tony

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/