Skip to content

myri10ge: limit the number of recoveries

Brice Goglin netdev 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1myri10ge: limit the number of recoveriesdrivers/net/myri10ge/myri10ge.c+10 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] myri10ge: limit the number of recoveries
Quoted 18 lines · Jeff Garzik
Quoted 17 lines · Brice Goglin

Limit the number of recoveries from a NIC hw watchdog reset to 1 by default.
It enables detection of defective NICs immediately since these memory parity
errors are expected to happen very rarely (less than once per century*NIC).
However, a defective NIC (very rare, fortunately) can see such an error quite often, ie. every few minutes under high load.

Make the limit tunable to allow people with mission critical installations
to crank up the tunable and recover an INTMAX number of times while waiting
for a downtime window to replace the NIC. The performance won't be optimal,
but at least, it will still work.

Quoted 6 lines
Quoted 4 lines
---
 drivers/net/myri10ge/myri10ge.c |   15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

NAK.

Ok...
Then please apply the following patch which limits the number of recovery to 1 without making it tunable. It will at least enable detection of bad NICs.

Brice