Skip to content

PCI: PM: Fix handling of device that can only signal PME from D3cold

Rafael J. Wysocki linux-acpi linux-pci linux-pm lkml 1 version In review

Get series with b4
b4 am 4668274.31r3eYUQgx@kreacher

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2PCI: PM: Add special case handling for PCIe device wakeupdrivers/pci/pci.c+10 -61 reply
1/2PCI: PM: Avoid forcing PCI_D0 for wakeup reasons inconsistentlydrivers/pci/pci.c+10 -61 reply
2/2PCI: PM: Enable PME if it can be signaled from D3colddrivers/pci/pci.c+8 -12 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchMika Westerberg
1/2R-b T-b
1/2R-b T-b
2/2R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH v1 0/2] PCI: PM: Fix handling of device that can only signal PME from D3cold

Hi,

This series is a replacement for the following patch:

https://patchwork.kernel.org/project/linux-pm/patch/3149540.aeNJFYEL58@kreacher/

allowing devices that only can signal PME from D3cold to be put into low-power states and signal wakeup from D3cold (if they get into it).

However, the patch above works by adding a special case to pci_pme_capable() which actually is not necessary.

Instead of doing that, it is sufficient to make pci_target_state() handle the case in which the device cannot signal PME from D0 consistently (patch [1/2] in this series) and make __pci_enable_wake() enable PM signaling for devices that can signal PME from D3cold (patch [2/2] in this series).

Please see the patch changelogs for details.

Thanks!