Skip to content

Introduce initial versions of new Command Config files.

Timur Tabi u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 19 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 19 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot-Users] [PATCH: cmdcfg: 00/19] Introduce initial versions of new Command Config files.
Quoted 10 lines · Wolfgang Denk
Quoted 6 lines · In message <[email protected]> you wrote:

#ifdef CONFIG_CMD_AUTOSCRIPT
#undef CONFIG_CMD_AUTOSCRIPT
#define CONFIG_CMD_AUTOSCRIPT CONFIG_CMD_AUTOSCRIPT #else
#define CONFIG_CMD_AUTOSCRIPT 0
#endif

#define foo foo ??? Not that looks uterly strange to me...

Sorry, that was a typo. I meant

#define CONFIG_CMD_AUTOSCRIPT CFG_CMD_AUTOSCRIPT

Quoted 3 lines
Quoted 1 line

... ( repeat for each CONFIG_CMD_x )

grrrghh....

It's still better than modifying dozens of source files!

Quoted 6 lines
Quoted 4 lines
#define CONFIG_COMMANDS \
	(CONFIG_CMD_AUTOSCRIPT | \
	CONFIG_CMD_x (repeat for each CONFIG_CMD_x)

Did you actually test if this works?

No exactly, but I use something similar in MPC8349ITX.h.

Quoted 6 lines
Quoted 3 lines

With this technique, you won't need to modify all of the source files that use CONFIG_COMMANDS.

But we *do* want to modify all files to move them to using the new scheme.

Only when we remove the old method entirely. This is a transitional patch - it allows config header files to use CONFIG_CMD_xxx today, and it avoids complicated #if pragmas in all those source files.

Signature · 2 lines
Timur Tabi
Linux Kernel Developer @ Freescale

Read the cover letter in its thread