Skip to content

Introduce initial versions of new Command Config files.

Timur Tabi u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 19 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 19 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot-Users] [PATCH: cmdcfg: 00/19] Introduce initial versions of new Command Config files.
Quoted 8 lines · Wolfgang Denk
Quoted 5 lines · In message <[email protected]> you wrote:

#define CONFIG_CMD_AUTOSCRIPT CFG_CMD_AUTOSCRIPT

Quoted 2 lines
Quoted 1 line

... ( repeat for each CONFIG_CMD_x )

grrrghh....

It's still better than modifying dozens of source files!

No, it's worse, as it would mean that such mess sticks forever.

Once every board header file has been converted to the new method, then you can remove all that gunk from cmd_confdefs.h and update the .c files. Jon's approach requires you to update the .c files twice - once now to add support for the new method, and again later to remove support for the old method.

Quoted 1 line

Let's do it once, and right, even if it's a painful operation.

I don't think "#if (CONFIG_COMMANDS & CFG_CMD_AUTOSCRIPT) || defined(CONFIG_CMD_AUTOSCRIPT" is doing it right the first time.

Signature · 2 lines
Timur Tabi
Linux Kernel Developer @ Freescale