libata: irq_on/off restructuring
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest9 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | libata: remove irq_on from ata_bus_reset() and ata_std_postreset()drivers/ drivers/ | +0 | 0 replies | |
| 2/9 | libata: add irq_off() for symmetrydrivers/ drivers/ drivers/ +1 more | +38 | 0 replies | |
| 3/9 | libata: add ->irq_off() to LLDDsdrivers/ drivers/ drivers/ +60 more | +129 | 0 replies | |
| 4/9 | libata: call irq_off from bmdma_freeze()drivers/ drivers/ | +2 | 0 replies | |
| 5/9 | libata: use freeze()/thaw() for pollingdrivers/ include/ | +5 | 1 reply | |
| 6/9 | libata: add freeze()/thaw() to old EH LLDDsdrivers/ drivers/ drivers/ +3 more | +31 | 0 replies | |
| 7/9 | libata: pdc_freeze() semantic changedrivers/ | +0 | 1 reply | |
| 8/9 | libata: remove writing of tf->ctl from ata_tf_load()drivers/ drivers/ drivers/ +1 more | +7 | 0 replies | |
| 9/9 | libata: remove irq_on/off and rename freeze()/thaw() to irq_on/offinclude/ | +2 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH/RFC 0/9] libata: irq_on/off restructuring
For ATA, there are two levels of mechanism available to turn irq on/off.
- device level: nIEN bit in the control register. nIEN masks INTRQ from the device.
- host adapter level: some controller can mask out per-port irq from the host adapter.
Currently various parts of libata deal with irq on/off.
ex. tf_load() can alter the nIEN bit.
ex. irq_on() also alters the device level nIEN bit. ex. freeze()/thaw() deal with the host adapter irq mask.
It seems these irq on/off codes could be better structured. Draft patches for your review/advice, thanks.
1/9: remove irq_on from ata_bus_reset() and ata_std_postreset() 2/9: add ->irq_off() for symmetry
3/9: implement ->irq_off() in LLDDs
4/9: call irq_off from bmdma_freeze()
5/9: use freeze()/thaw() for polling
6/9: add freeze()/thaw() to old EH LLDDs
7/9: pdc_freeze() semantic change
8/9: remove writing of tf->ctl from ata_tf_load() 9/9: Remove irq_on/off. Rename freeze()/thaw() to irq_on/off.