libata: irq_on/off restructuring
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest10 patches 6 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | libata: remove irq_on from ata_bus_reset() and ata_std_postreset()drivers/ drivers/ | +0 | 1 reply | |
| 2/10 | libata: add irq_offdrivers/ drivers/ drivers/ +1 more | +38 | 0 replies | |
| 3/10 | libata: implement ->irq_off in LLDDsdrivers/ drivers/ drivers/ +60 more | +130 | 0 replies | |
| 4/10 | libata: call irq_off from bmdma_freeze()drivers/ drivers/ | +2 | 0 replies | |
| 5/10 | libata: use freeze/thaw for pollingdrivers/ include/ | +5 | 0 replies | |
| 6/10 | libata: add freeze/thaw to old EH LLDDsdrivers/ drivers/ drivers/ +3 more | +31 | 0 replies | |
| 7/10 | libata: pdc_freeze() semantic changedrivers/ | +0 | 0 replies | |
| 8/10 | libata: remove writing of tf->ctl from ata_tf_load()drivers/ drivers/ drivers/ +1 more | +7 | 3 replies | |
| 9/10 | libata: Integrate freeze/thaw with irq_on/offdrivers/ drivers/ drivers/ +1 more | +19 | 0 replies | |
| 10/10 | libata: Integrate freeze/thaw with irq_on/off in LLDDsdrivers/ drivers/ drivers/ +60 more | +74 | 0 replies |
Reviews trailers per patch
1 of 10 patches has a Reviewed-by or Acked-by.
| Patch | Tejun Heo |
|---|---|
| 1/10 | A-b |
| 2/10 | |
| 3/10 | |
| 4/10 | |
| 5/10 | |
| 6/10 | |
| 7/10 | |
| 8/10 | |
| 9/10 | |
| 10/10 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/10] libata: irq_on/off restructuring
For ATA, there are two levels of mechanism available to turn irq on/off.
- device level: nIEN bit in the control register. This masks INTRQ from the device.
- host adapter level: some controller can mask out per-port irq from the host adapter.
Currently various parts of libata deal with irq on/off.
ex. tf_load() can alter the nIEN bit.
ex. irq_on() also alters the device level nIEN bit. ex. freeze()/thaw() deal with the host adapter irq mask.
It seems these irq on/off codes could be better structured. Patches against libata-dev tree for your review/advice, thanks.
1/10: remove irq_on from ata_bus_reset() and ata_std_postreset() 2/10: add ->irq_off() for symmetry
3/10: implement ->irq_off() in LLDDs
4/10: use irq_off from bmdma_freeze()
5/10: use freeze()/thaw() for polling
6/10: add freeze()/thaw() to old EH LLDDs
7/10: pdc_freeze() semantic change
8/10: remove writing of tf->ctl from ata_tf_load() 9/10: integrate freeze()/thaw() with irq_on/off. 10/10: integrate freeze/thaw with irq_on/off in LLDDs