libata: irq_on/off restructuring (take #2)
Status from this message: applied
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | libata: remove irq_on from ata_bus_reset() and ata_std_postreset()drivers/ drivers/ | +0 | 1 reply | |
| 2/7 | sata_promise: pdc_freeze() semantic changedrivers/ | +0 | 1 reply | |
| 3/7 | libata: add freeze/thaw to old EH LLDDsdrivers/ drivers/ drivers/ +3 more | +31 | 0 replies | |
| 4/7 | libata: use freeze/thaw for polling PIOdrivers/ include/ | +5 | 1 reply | |
| 5/7 | libata: integrate freeze/thaw with irq_on/offdrivers/ drivers/ drivers/ +65 more | +231 | 2 replies | |
| 6/7 | libata: remove nIEN handling from ata_tf_load()drivers/ drivers/ drivers/ +1 more | +13 | 0 replies | |
| 7/7 | libata: remove ap->last_ctldrivers/ drivers/ drivers/ +1 more | +0 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/7] libata: irq_on/off restructuring (take #2)
(Revised per Tejun's advice.)
For ATA, there are two levels of mechanism available to turn irq on/off.
- device level: nIEN bit in the control register. This masks INTRQ from the device.
- host adapter level: some controllers can mask out per-port irq from the host adapter.
Currently various parts of libata deal with irq on/off.
ex. tf_load() can alter the nIEN bit.
ex. irq_on() also alters the device level nIEN bit. ex. freeze()/thaw() deal with the host adapter irq mask.
It seems these irq_on/off codes could be better structured. Patches against the libata-dev tree for your review, thanks.
1/7: remove irq_on from ata_bus_reset() and ata_std_postreset() 2/7: sata_promise::pdc_freeze() semantic change
3/7: add freeze()/thaw() to old EH LLDDs
4/7: use freeze()/thaw() for polling PIO
5/7: integrate freeze/thaw with irq_on/off
6/7: tf_load() cleanup
7/7: remove ap->last_ctl