Skip to content

aha152x.c - Cleanup, need help in testing and auditing

Boaz Harrosh linux-scsi 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 22 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4aha152x.c - Preliminary fixes and some commentsdrivers/scsi/aha152x.c+4 -40 replies
2/4aha152x.c - Clean Reset pathdrivers/scsi/aha152x.c+9 -140 replies
3/4aha152x.c - Fix check_condition code-pathdrivers/scsi/aha152x.c+27 -280 replies
4/4aha152x.c - use data accessors and !use_sg cleanupdrivers/scsi/aha152x.c+47 -440 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [patch 0/4] aha152x.c - Cleanup, need help in testing and auditing

In motivation for the !use_sg cleanup and use of accessors I needed to do some restructuring of the aha152x.c driver.

I have tried to be as careful as I could, but with out the hardware for testing, it is hard. Christoph and James You are signed on a couple of the last patches to this driver So you are probably somewhat familiar with the code. Could you please review the patchset to see that nothing is broken.

If any one has an Hardware that uses aha152x.c, please help me with testing this patchset. If it does not work could you please do a short bisect of which patch breaks out of the 4.

The problematic parts were that the driver writes all over the scsi_cmnd members in couple of places. To untangle that I divided the work to stages for easier review and testing. I was very verbose at each patch explanation, mainly for myself to try and prove that the changes are sound.

[patch 1/4] aha152x.c - Preliminary fixes and comments
Some weird typos and some hard coded numbers made the code very hard to understand.

[patch 2/4] aha152x.c - Clean Reset path
On the Reset code path the driver would save, write, than restore scsi_cmnd members. Here I propose a solution that does not need to do that.

[patch 3/4] aha152x.c - Fix check_condition code-path
In case of a Status return from a target. The driver would re-queue the command with a REQUEST_SENSE read. Again save, write, restore. I cleaned that up to a stage I can be happy with. Also while at it I fixed a BUG with "resid".

[patch 4/4] aha152x.c - use data accessors and !use_sg cleanup
And now everything is ready for this one.

Thanks for any help
Boaz