Skip to content

gdth combined patchset & call for testers

Boaz Harrosh linux-scsi 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest16 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16gdth: Make one abuse of scsi_cmnd less obviousdrivers/scsi/gdth.c+20 -170 replies
2/16gdth: Stop abusing ->done for internal commandsdrivers/scsi/gdth.c drivers/scsi/gdth_proc.c+13 -100 replies
3/16gdth: split out isa probingdrivers/scsi/gdth.c+162 -1340 replies
4/16gdth: split out eisa probingdrivers/scsi/gdth.c+159 -1260 replies
5/16gdth: split out pci probingdrivers/scsi/gdth.c+167 -1450 replies
6/16gdth: Remove 2.4.x support, in-kernel changelogdrivers/scsi/gdth.c drivers/scsi/gdth.h drivers/scsi/gdth_kcompat.h +1 more+2 -4530 replies
7/16gdth: kill gdth_{read,write}[bwl] wrappersdrivers/scsi/gdth.c+153 -1600 replies
8/16gdth: Reorder scsi_host_template intitializersdrivers/scsi/gdth.c+3 -30 replies
9/16gdth: Remove virt hostsdrivers/scsi/gdth.c drivers/scsi/gdth_proc.c drivers/scsi/gdth_proc.h+25 -950 replies
10/16gdth: clean up host private datadrivers/scsi/gdth.c drivers/scsi/gdth.h drivers/scsi/gdth_proc.c +1 more+291 -3840 replies
11/16gdth: gdth_interrupt() gdth_get_status() & gdth_wait() fixesdrivers/scsi/gdth.c+43 -500 replies
12/16gdth: switch to modern scsi host registrationdrivers/scsi/gdth.c drivers/scsi/gdth.h+157 -1640 replies
13/16gdth: Remove gdth_ctr_tab[]drivers/scsi/gdth.c+50 -570 replies
14/16gdth: Setup proper per-command private datadrivers/scsi/gdth.c drivers/scsi/gdth.h drivers/scsi/gdth_proc.c+91 -360 replies
15/16gdth: Move members from SCp to gdth_cmndinfo, stage 2drivers/scsi/gdth.c drivers/scsi/gdth.h drivers/scsi/gdth_proc.c+104 -910 replies
16/16gdth: !use_sg cleanup and use of scsi accessorsdrivers/scsi/gdth.c drivers/scsi/gdth.h+109 -1260 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [0/16 ver2] gdth combined patchset & call for testers

Hi!

following is an attempted at unified patchset for the gdth driver.

They try to incorporate floating patches to gdth from:
Christoph Hellwig
Jeff Garzik
Matthew Wilcox
and Me Boaz Harrosh

They are done in the mindset of "likelihood of inducing breakage", hence the need for testers. Christoph & Jeff please review for any obvious easy-to-catch bugs. Also there was a massive code shifts and rebasing I hope nothing was lost.

The differences from last set are:
- Matthews patches are first so they can go in. They are a bit modified so please take these and not the original. Mainly they restrain from cleanups

- Fix Christoph bug that was spotted by jeff of the misplaced #endif. Also when compiling with out CONFIG_{ISA,EISA,PCI} compiler would complain about unused params, functions and so on so fixed that.

- More Aggressive fix for gdth_interrupt() and friends Christoph pleeeeeeease review.

- Rebasing to all above. I hope I'll get the From:
right this time

Some short explanations:
[01/16] gdth: Make one abuse of scsi_cmnd less obvious - Matthew Wilcox [02/16] gdth: Stop abusing ->done for internal commands - Matthew Wilcox
Patches from Matthew, but cleaned for future patchability.

[03/16] gdth: split out isa probing - Christoph Hellwig [04/16] gdth: split out eisa probing - Christoph Hellwig [05/16] gdth: split out pci probing - Christoph Hellwig
These three are from Christoph and where ACKed by Jeff at the time. Revised by me for warning fixes when one of the buses ISA/EISA/PCI is not defined.

[06/16] gdth: Remove 2.4.x support, in-kernel changelog - Jeff Garzik
Same but partial work was done both by Christoph and Matthew.

[07/16] gdth: kill gdth_{read,write}[bwl] wrappers - Jeff Garzik [08/16] Reorder scsi_host_template intitializers
[09/16] gdth: Remove virt hosts - Christoph && Boaz
Here we need an executive decision! The issue is as stated by Christoph:

"The virt_ctr option allows to register a new scsi_host for each bus on the raid controller. This non-default option makes no sense with the current scsi code and prevents cleaning up the host registration, so remove it."

I agree. This is just exactly the same as done buy scsi-ml scans but only more resource consuming. Unless I'm totally missing something, perhaps it is just a leftover from old kernels.

[10/16] gdth: clean up host private data - Christoph && Boaz
This is based on the same patch from Christoph, but taken one step farther, by just passing the ha pointer everywhere instead of hanum.

[11/16] gdth_interrupt gdth_get_status & gdth_wait fixes - Boaz
This logically belongs to [9/16] but is separated for reviewing and bisect-ability As it is a sensitive matter.
It is done aggressively this time around Please review!

[12/16] gdth: switch to modern scsi host registration - Christoph
Christoph what is missing from here is the remove of the deprecated pci_find_device() call. Can I Just use pci_get_device() of the same signature or do I need to call some other pci_ members after that?

[13/16] gdth: Remove gdth_ctr_tab[] - Boaz
I took Christoph's cleanup one step farther and got read of the statically allocated gdth_ctr_tab[]. In it's place I use the new link-list introduced by the [11/16] patch.

[14/16] gdth: Setup proper per-command private data - Boaz [15/16] gdth: Move members from SCp to gdth_cmndinfo, stage 2 - Boaz
These two move me much closer to the agenda I had in all this, which is: "gdth diss-abuse of of scsi_cmnd IO members". With these patches I also conform to Matthew's second patch:
"gdth: Stop abusing ->done for internal commands"

[16/16] gdth: !use_sg cleanup and use of scsi accessors
And finally this one.

Boaz