Skip to content

Consolidate cgroup files creation for resource counters (v2)

Pavel Emelyanov containers 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Typedefs the read and write functions in cftypeinclude/linux/cgroup.h+11 -61 reply
2/3Introduce the res_counter_populate() functioninclude/linux/res_counter.h kernel/res_counter.c+49 -03 replies
3/3Use the res_counter_populate in memory controllermm/memcontrol.c+9 -160 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchPaul Menage
1/3A-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] Consolidate cgroup files creation for resource counters (v2)

Changes from previous version
* made the names configurable
* fixed race between res_counter_populate and reading any of these files (memset to zero could spoof the pointers)

Right now we have only one controller in -mm tree - the memory one - and it initializes all its files manually. After I developed the kernel memory one it turned out, that the names of resource counter specific files has changed. In the future, if anything in the resource counters change, we'll have to rewrite all the controllers we will have by that time.

To make all the containers working with the resource counters look similar I propose to create the resource counters specific files in one place.