Skip to content

pluto/fc - some fixes and cleanups

Boaz Harrosh linux-scsi 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3pluto/fc - Remove uses of the scsi_cmnd->donedrivers/fc4/fc.c drivers/fc4/fcp_impl.h drivers/scsi/pluto.c+23 -521 reply
2/3pluto/fc - Enable compilation for all ARCHsarch/sparc64/Kconfig drivers/Kconfig+2 -26 replies
3/3pluto/fc - fix INQUIRY still using !use_sg commandsdrivers/fc4/fc.c drivers/fc4/fcp_impl.h drivers/scsi/pluto.c+24 -130 replies
3/3pluto/fc - fix INQUIRY still using !use_sg commandsdrivers/fc4/fc.c drivers/fc4/fcp_impl.h drivers/scsi/pluto.c+28 -161 reply
3/3pluto/fc - fix INQUIRY still using !use_sg commandsdrivers/fc4/fc.c drivers/fc4/fcp_impl.h drivers/scsi/pluto.c+28 -180 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCHSET 0/3] pluto/fc - some fixes and cleanups

I'm sending a small lift-up to the drivers/scsi/pluto.c and drivers/fc4/fc.c pair, that where a bit stepped on lately.

Matthew this includes your patch, I just fixed up the patch comment, since You had a good comment on the first patch but sent a better second patch with no comment. (And my set depends on yours so just to make sure.)

This is only compile tested, and from patch 3/3 below the driver is in grate need of testers.

[patch 1/3] pluto/fc - Remove uses of the scsi_cmnd ->done
This is Matthew's patch with right commit-log inline?

[patch 2/3] pluto/fc - Enable compilation for all ARCHs
I'm not sure if the final verdict was yes on this one, but it's what I needed in order to compile this.

[patch 3/3] pluto/fc - fix INQUIRY still using !use_sg commands
So this is broken and, can some body explain to me how this was checked, because it looks to me that it should surely crash terribly. pluto.c would send use_sg == 0 command on detection but fc.c was already converted.
What this patch does is effectively reverts some of Tomo's !use_sg cleanup, but only for the INQUIRY command that is issued internally by pluto.c. (Sorry)

Happy testing
Boaz