Skip to content

Fix two PEIe hotplug issues

Mark Lord lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 16 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3pciehp_handle_preinserted_carddrivers/pci/hotplug/pciehp.h drivers/pci/hotplug/pciehp_core.c drivers/pci/hotplug/pciehp_ctrl.c+0 -00 replies
1/3pciehp: hotplug: deal with pre-inserted ExpressCardsdrivers/pci/hotplug/pciehp.h drivers/pci/hotplug/pciehp_core.c drivers/pci/hotplug/pciehp_ctrl.c+0 -05 replies
2/3pciehp_split_pcie_initdrivers/pci/hotplug/pciehp_hpc.c+0 -00 replies
2/3pciehp: hotplug: split out hardware init from pcie_init()drivers/pci/hotplug/pciehp_hpc.c+0 -00 replies
3/3pciehp_resume_reinit_hardwaredrivers/pci/hotplug/pciehp.h drivers/pci/hotplug/pciehp_core.c drivers/pci/hotplug/pciehp_ctrl.c+0 -00 replies
3/3pciehp: hotplug: reinit hotplug h/w on resume from suspenddrivers/pci/hotplug/pciehp.h drivers/pci/hotplug/pciehp_core.c drivers/pci/hotplug/pciehp_ctrl.c+0 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Fix two PEIe hotplug issues

Fix PCIe Hotplug so that it works with ExpressCard slots on Dell notebooks (and others?) in conjunction with the modparam of pciehp_force=1.

The PCIe Hotplug driver has two issues when used on Dell notebooks which lack ACPI BIOS support for PCIe hotplug:

1. The driver does not recognise cards that were inserted prior to the driver being modprobe'd.

2. The driver stops functioning after a suspend/resume (RAM) cycle, and needs to be rmmod'd and modprobe'd to get it working again.

This patch series addresses those issues, resulting in a completely functional PCIe Hotplug driver for Dell notebooks, and possibly others as well which may lack ACPI BIOS support for this.
Note that pciehp_force=1 is (still) required.

There are three patches in this series:

01_pciehp_handle_preinserted_card.patch
-- fixes problem number 1 (above).

02_pciehp_split_pcie_init.patch
-- preparation for the resume patch.

03_pciehp_resume_reinit_hardware.patch
-- fixes problem number 2 (above).

diffstat summary for the three patches combined:

drivers/pci/hotplug/pciehp.h      |    3
drivers/pci/hotplug/pciehp_core.c |   23 +++
drivers/pci/hotplug/pciehp_ctrl.c |    2
drivers/pci/hotplug/pciehp_hpc.c  |  185 +++++++++++++++-------------
4 files changed, 130 insertions(+), 83 deletions(-)

Cheers
--
Mark Lord <[email protected]>