Cleanup/fix the sk_alloc() call
Status from this message: Applied.
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | Move the sock_copy() from the headerinclude/ net/ | +14 | 1 reply | |
| 2/8 | Move the get_net() from sock_copy()net/ | +1 | 1 reply | |
| 3/8 | Cleanup the allocation/freeing of the sock objectnet/ | +29 | 1 reply | |
| 4/8 | Auto-zero the allocated sock objectnet/ | +3 | 1 reply | |
| 5/8 | Move some core sock setup into sk_prot_allocnet/ | +27 | 1 reply | |
| 6/8 | Make the sk_clone() lighternet/ | +3 | 3 replies | |
| 7/8 | Remove bogus zero_it argument from sk_allocnet/ | +9 | 1 reply | |
| 8/8 | Forget the zero_it argument of sk_alloc()drivers/ drivers/ include/ +30 more | +43 | 1 reply |
Reviews trailers per patch
None of the 8 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Arnaldo Carvalho de Melo |
|---|---|
| Series | A-b |
| 1/8 | |
| 2/8 | |
| 3/8 | |
| 4/8 | |
| 5/8 | |
| 6/8 | |
| 7/8 | |
| 8/8 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/8] Cleanup/fix the sk_alloc() call
The sk_alloc() function suffers from two problems:
1 (major). The error path is not clean in it - if the security
call fails, the net namespace is not put, if the try_module_get fails additionally the security context is not released;
2 (minor). The zero_it argument is misleading, as it doesn't just
zeroes it, but performs some extra setup. Besides this argument is used only in one place - in the sk_clone().
So this set fixes these problems and performs some additional cleanup.
Signed-off-by Pavel Emelyanov <[email protected]>