Last 3 patches for bidi support
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 16 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | scsi_tgt_lib: Use scsi_init_io instead of scsi_alloc_sgtabledrivers/ drivers/ include/ | +17 | 5 replies | |
| 2/3 | scsi_data_bufferdrivers/ drivers/ drivers/ +7 more | +92 | 7 replies | |
| 3/3 | SCSI: bidi supportdrivers/ drivers/ include/ +1 more | +149 | 0 replies |
Reviews trailers per patch
None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | FUJITA Tomonori |
|---|---|
| Series | A-b |
| 1/3 | |
| 2/3 | |
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [0/3] Last 3 patches for bidi support
[1]
I propose a small change to scsi_tgt_lib.c that will make tgt completely neutral to the scsi_data_buffer patch. And will make it all that more ready for bidi, too. TOMO is this OK?
(Can you do without the GFP_KERNEL allocation flag? It could make the code a bit more simple)
[2]scsi_data_buffer patch.
As requested by TOMO the all patch is squashed into one, 600 and some lines. TOMO if it makes you happy, OK, here it is.
There is one hunk from libsrp.c that I really hate. and from what I understand of the code, only the "request_bufflen =" is really used, All users of "request_buffer = addr" pass NULL, as far as I can see. If you would like to make me happy, and it is at all possible, please clean it.
[3]
Once scsi_data_buffer is in, then scsi bidi support can be applied. (Block bidi was already merged 3 kernels ago). It makes no changes to scsi_cmnd and only adds some, not-at-all-dangerous, code to scsi_lib. So I don't see any reason to wait. please all review.
If ACKed by all parties and applied for inclusion for 2.6.25, then they will have a long time to sit in MM and collect compilation breakage reports from ARCHs we never compiled.
I wish these make everybody happy this time
Boaz Harrosh