Skip to content

UDP memory accounting and limitation (take 8)

Hideo AOKI netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5udp: fix send buffer checknet/ipv4/ip_output.c+5 -00 replies
2/5udp: accounting unit and variableinclude/net/sock.h include/net/udp.h net/ipv4/proc.c +1 more+14 -10 replies
3/5udp: memory accountingnet/ipv4/af_inet.c net/ipv4/ip_output.c net/ipv4/udp.c+61 -40 replies
4/5udp: memory limitation by using udp_memDocumentation/networking/ip-sysctl.txt include/net/udp.h net/ipv4/af_inet.c +3 more+91 -35 replies
5/5udp: add udp_rmem_min and udp_wmem_minDocumentation/networking/ip-sysctl.txt include/net/udp.h net/ipv4/ip_output.c +2 more+50 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] UDP memory accounting and limitation (take 8)

Hello,

This is the latest patch set of UDP memory accounting and limitation.

I modified sk_datagram_pages() to avoid using divide instruction.

In addition, I also fixed memory accounting code in udp_recvmsg(), since, in previous takes, the accounting code referred released sk_buff's truesize. The fix can be found in 3rd patch of the patch set.

The patch set is for net-2.6. Please apply.

Changelog take 7 -> take 8:
* sk_datagram_pages(): avoided using divide instruction
* udp_recvmsg(): fixed referring released truesize in accounting

Changelog take 6 -> take 7:
* renamed /proc/sys/net/ipv4/udp_rmem to
/proc/sys/net/ipv4/udp_rmem_min
* renamed /proc/sys/net/ipv4/udp_wmem to
/proc/sys/net/ipv4/udp_wmem_min
* rebased to net-2.6

Changelog take 5 -> take 6:

* removed minimal limit of /proc/sys/net/ipv4/udp_mem
* added udp_init() for default value calculation of parameters
* added /proc/sys/net/ipv4/udp_rmem and /proc/sys/net/ipv4/udp_rmem
* added limitation code to ip_ufo_append_data()
* improved accounting for receiving packet
* fixed typos
* rebased to 2.6.24-rc1

Changelog take 4 -> take 5:

* removing unnessesary EXPORT_SYMBOLs
* adding minimal limit of /proc/sys/net/ipv4/udp_mem
* bugfix of UDP limit affecting protocol other than UDP
* introducing __ip_check_max_skb_pages()
* using CTL_UNNUMBERED
* adding udp_mem usage to Documentation/networking/ip_sysctl.txt

Best regards,
Hideo Aoki

--
Hitachi Computer Products (America) Inc.