simplify kvm-userspace to qemu-kvm callback structure
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest1 patch 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/1 | simplify kvm-userspace to qemu-kvm callback structurelibkvm/ libkvm/ qemu/ +1 more | +19 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH] [0/1] simplify kvm-userspace to qemu-kvm callback structure
Well no response might mean that there is nothing to be said against this simplification ;-)
Because of that I completed the patch (main.c as well) and corrected some whitespace issues I had before.
Quoted 15 lines · Christian Ehrhardt
Background:
In our ppc code for the demo we only needed a call tocpu_physical_memory_rwto handle all kind of mmio we needed. Looking at all the callback pointers for read/write mmio inkvm_callbacksI wondered if this can be simplified withcpu_physical_memory_rwfor x86 too. So I tested it today and it works fine on with kvm-svm on my opteron. The only code that did not just redirect to another function was a workaround for a Redhat 7.1 issue, so I merged it in the central call making it easier to find and maintain (was split before) anyway. If everyone agrees with it I will create a new patch also affecting the other implementations of this interface e.g.user/main.cand a rebased version of this one.
But maybe there was a reason to do it that split way with all the callback pointers that was not obvious to me, so please comment. [...]
Signature · 20 lines
Grüsse / regards, Christian Ehrhardt IBM Linux Technology Center, Open Virtualization +49 7031/16-3385 [email protected] [email protected] IBM Deutschland Entwicklung GmbH Vorsitzender des Aufsichtsrats: Johann Weihen Geschäftsführung: Herbert Kircher Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294 ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php