Skip to content

call FIB rule->action in the correct namespace

Denis V. Lunev containers netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Add netns to fib_rules_ops.include/net/fib_rules.h net/decnet/dn_rules.c net/ipv4/fib_rules.c +1 more+5 -00 replies
2/3FIB rules API cleanup.include/net/fib_rules.h net/core/fib_rules.c net/decnet/dn_rules.c +2 more+22 -160 replies
3/3Process FIB rule action in the context of the namespace.include/net/fib_rules.h net/core/fib_rules.c net/ipv4/fib_rules.c+4 -10 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDaniel Lezcano
SeriesA-b
1/3A-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3 net-2.6.25] call FIB rule->action in the correct namespace

FIB rule->action should operate in the same namespace as fib_lookup. This is definitely missed right now.

There are two ways to implement this: pass struct net into another rules API call (2 levels) or place netns into rule struct directly. The second approach seems better as the code will grow less.

Additionally, the patchset cleanups struct net from fib_rules_register/unregister to have network namespace context at the time of default rules creation.