Skip to content

Change SG_ALL to mean "any size"

Boaz Harrosh linux-scsi 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 of 8 patches 15 repliesIn review

7 of 8 patches are in this archive. The cover letter announces 8.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8firewire: ieee1394: Move away from SG_ALLdrivers/firewire/fw-sbp2.c drivers/ieee1394/sbp2.c drivers/ieee1394/sbp2.h+8 -44 replies
2/8scsi-drivers Don't use SG_ALL as allocation sizedrivers/scsi/atari_scsi.c drivers/scsi/atari_scsi.h drivers/scsi/eata_pio.c +8 more+32 -154 replies
3/8NCR5380: Not sg-chain readydrivers/scsi/NCR5380.h drivers/scsi/arm/cumana_1.c drivers/scsi/arm/oak.c +8 more+16 -220 replies
4/8wd33c93: Not sg-chain readydrivers/scsi/a2091.c drivers/scsi/a3000.c drivers/scsi/gvp11.c +3 more+7 -50 replies
5/8arm/scsi: Not sg-chain readydrivers/scsi/arm/acornscsi.c drivers/scsi/arm/arxescsi.c drivers/scsi/arm/cumana_2.c +3 more+7 -50 replies
7/8a100u2w: advansys: initio: Wrong use of SG_ALLdrivers/scsi/a100u2w.c drivers/scsi/advansys.c drivers/scsi/initio.c+5 -80 replies
8/8Change SG_ALL to mean "any size"include/scsi/scsi_host.h+2 -40 replies

Reviews trailers per patch

1 of 7 patches has a Reviewed-by or Acked-by.

PatchStefan Richter
1/8A-b
2/8
3/8
4/8
5/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [patch 0/8] Change SG_ALL to mean "any size"

I have scanned through the scsi tree and checked all places that used SG_ALL. Those drivers that where not ready for SG_ALL to mean "any size" where changed to what ever is appropriate for this driver. Mainly 3 groups.

Those that meant SG_ALL == 255:

[PATCH 1/8] firewire: ieee1394: Move away from SG_ALL [PATCH 2/8] scsi-drivers Don't use SG_ALL as allocation size

Those who are not sg-chaining ready:

[PATCH 3/8] NCR5380: Not sg-chain ready [PATCH 4/8] wd33c93: Not sg-chain ready [PATCH 5/8] arm/scsi: Not sg-chain ready [PATCH 6/8] scsi: Drivers not ready for sg-chaining

And those that just got confused:
[PATCH 7/8] a100u2w: advansys: initio: Wrong use of SG_ALL

And finally the switch of SG_ALL to ~0, that is MAX_ what ever type it is.
[PATCH 8/8] Change SG_ALL to mean "any size"

Please request if you want any patches squashed or split.

These are based on the scsi-bidi git-tree and mainly on top of the: "[SCSI] remove use_sg_chaining" patch. James do you want that I reverse the dependency so your patch will be on top of these patches? (For bisect-ability)

Boaz