gdth: fix 2.6.24 driver breakage

Boaz Harrosh linux-scsi lkml 1 version Feb 12, 2008 In review

Get series with b4

b4 am [email protected]

Versions newest first

v1 Latest Feb 12, 20082 patches 18 repliesIn review

Patches in v1 No applies recorded yet

#	Subject and files	Size	Replies	Applied
1/2	gdth: scan for scsi devices`drivers/scsi/gdth.c`	+9 -0	1 reply
2/2	gdth: bugfix for the Timer at exit crash`drivers/scsi/gdth.c`	+8 -7	21 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

Patch	Joerg Dorchain:	Stefan Priebe	Jon Chelton
1/2	T-b	T-b	T-b
2/2		T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [BUGFIXES 0/2] gdth: fix 2.6.24 driver breakage

Quoted 49 lines · Boaz Harrosh

Quoted 48 lines · Sven Köhler
Hi,
so i have upgraded a system to kernel 2.6.24. After that, it failed to boot with the usual message telling, that the rootfs on device /dev/sda1
cannot be mounted (a raid1 run by the controller below).
With 2.6.23.12, everything is working fine.
# lspci -v:
03:01.0 RAID bus controller: Intel Corporation RAID Controller
Subsystem: Intel Corporation Unknown device 01db
Flags: bus master, 66MHz, slow devsel, latency 64, IRQ 17 Memory at ddffc000 (32-bit, prefetchable) [size=16K] [virtual] Expansion ROM at deef0000 [disabled] [size=32K]
Capabilities: [80] Power Management version 2
# GDT-related dmesg output (2.6.23.12):
GDT-HA: Storage RAID Controller Driver. Version: 3.05
ACPI: PCI Interrupt 0000:03:01.0[A] -> GSI 24 (level, low) -> IRQ 17
GDT-HA: Found 1 PCI Storage RAID Controllers
Configuring GDT-PCI HA at 3/1 IRQ 17
GDT-HA 0: Name: SRCU42L
scsi0 : SRCU42L
scsi 0:0:0:0: Direct-Access     Intel    Host Drive  #00       PQ: 0 ANSI: 2
scsi 0:2:6:0: Processor         ESG-SHV  SCA HSBP M29     1.06 PQ: 0 ANSI: 2
sd 0:0:0:0: [sda] 143299800 512-byte hardware sectors (73369 MB) sd 0:0:0:0: [sda] Assuming Write Enabled
sd 0:0:0:0: [sda] Assuming drive cache: write through sd 0:0:0:0: [sda] 143299800 512-byte hardware sectors (73369 MB) sd 0:0:0:0: [sda] Assuming Write Enabled
sd 0:0:0:0: [sda] Assuming drive cache: write through
sda: sda1 sda2 < sda5 >
sd 0:0:0:0: [sda] Attached SCSI disk
# cat /boot/config-2.6.24 |grep GDT
CONFIG_SCSI_GDTH=y
Any ideas?
http://www.kernel.org/diff/diffview.cgi?file=%2Fpub%2Flinux%2Fkernel%2Fv2.6%2Fpatch-2.6.24.bz2
show huge drivers/scsi/gdth* related changes.

Quoted 8 lines

Quoted 6 lines
Can't test at the moment. System went production.
Regards,
Sven
Hi Sven!

<snip>

With the kind help of:
Joerg Dorchain: <[email protected]>
Jon Chelton <[email protected]>
Stefan Priebe <[email protected]>

Which let me take up their machines their effort and their time I hope I'm able to fix the gdth driver for the 2.6.24 kernel and forward. Actually it was a simple miss by Christoph, but with my inexperience it took me a bisection and a while to get it.

Both Joerg, and Stefan where able to boot with these patches and work on their machine. Jon Chelton's disks array should also work, we're testing.

Submitted 2 patches. They should also be included after some testing into the 2.6.24.x stable releases. (Will be posted after some more testing)

[PATCH 1/2] gdth: scan for scsi devices
simple but must fatal.

[PATCH 2/2] gdth: bugfix for the Timer at exit crash
James please inspect and comment on this patch. It was not yet tested by the original bug submitter.

In the original gdth series Christoph has forgotten to add the call to scsi_scan_host(). Jeff alternative patches did do the scan. After everything was probed, the code would loop on all found cards and scan. However I like to individually scan at each probe, because I think this way it is more ready for the hot-plug API where the discovery is done outside of the driver, and the probe is called on single host at a time. Is that right? please comment.

Test away.

Meany thanks to Joerg, Jon && Stefan, Cheers.

Boaz

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Read the cover letter in its thread