Skip to content

Stop calling request_irq(), etc. with invalid IRQs in the USB drivers`

Sergey Shtylyov linux-usb 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 6 repliesIn review
  2. v28 of 9 patches 9 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2usb: host: ohci-tmio: add IRQ checkdrivers/usb/host/ohci-tmio.c+3 -01 reply
2/2usb: phy: tahvo: add IRQ checkdrivers/usb/phy/phy-tahvo.c+3 -11 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchAlan SternFelipe Balbi
1/2A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] Stop calling request_irq(), etc. with invalid IRQs in the USB drivers`

Here are 2 patches against the 'usb-linus' branch of GregKH's 'usb.git' repo. The affected drivers call platform_get_irq() but largely ignore its result -- they blithely pass the negative error codes to request_irq() (and its ilk) which expects *unsinged* IRQ #s. Stop doing that by checking what exactly platform_get_irq() returns.

I've removed 7 patches that GregKH has applied to the usb-testing' branch (holler if this isn't enough).

[1/2] usb: host: ohci-tmio: add IRQ check
[2/2] usb: phy: tahvo: add IRQ check