Skip to content

RFC block large commands support continue

Boaz Harrosh linux-ide linux-scsi 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest5 patches 15 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5block: no need to initialize rq->cmdblock/scsi_ioctl.c drivers/block/pktcdvd.c drivers/block/ps3disk.c +5 more+0 -121 reply
2/5block: replace sizeof(rq->cmd) with BLK_MAX_CDBblock/blk-core.c drivers/ide/ide-cd.c drivers/ide/ide-cd_verbose.c+5 -50 replies
3/5block: Export rq_init, rename to blk_init_rqblock/blk-barrier.c block/blk-core.c block/blk.h +1 more+8 -370 replies
4/5block: Use new blk_init_rqdrivers/block/nbd.c drivers/block/paride/pd.c drivers/ide/ide-io.c +4 more+9 -90 replies
5/5block: add large command supportblock/blk-core.c include/linux/blkdev.h+11 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 0/5] block large commands support continue

The support for large commands was dropped from the for-2.6.26 branch and will probably not get accepted into next kernel.

I have tried to take all comments from Jens and Bart. and incorporate it into a new patchset. This is basically Tomo's patchset but with proposed changes.

They are based on current linux-block/master. They will probably conflict with latest patch sent by Tomo for the blk_get_request(). Once those patches get accepted at some git tree, (Where will that be?), I will rebase these on top of them. Please CC me of any progress.

[PATCH 1/5] block: no need to initialize rq->cmd
This is 2 of Tomo's patches squashed together as they are small and do the same. Tomo is this OK?

[PATCH 2/5] block: replace sizeof(rq->cmd) with BLK_MAX_CDB
Tomos patch rebased to here

[PATCH 3/5] block: Export rq_init, rename to blk_init_rq
[PATCH 4/5] block: Use new blk_init_rq
These patches are basically what Jens and Bart has suggested, that with a small code change to blk-core.c we can memset at rq_init() and only set none zero members. We can also export that initializer and use it all over the ide tree where ever requests don't come from a request queue. (OK also at scsi_error.c)

[PATCH 5/5] block: add large command support
Now that all initialization goes through one place Tomos large command support is trivial.

Bart. This is mostly ide changes, so please if you can test it. I do not have any legacy IDE devices here at the office, it is all new sata stuff.

I hope we can put this, and later the scsi stuff, on some tree that can be tested at -mm and hopefully be ready for 2.6.27

Thanks
Boaz