DM9000: Several fixes/cleanups for the DM9000A controller
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 6 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 6 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [U-Boot-Users] [patch 0/6] DM9000: Several fixes/cleanups for the DM9000A controller
Quoted 24 lines · Remy Bohmer
Hello Stefano,
Quoted 2 lines
Great ! It works, I tested now with bigger files and it sounds good !
Good news!
Quoted 4 lines
I have seen that the complete patch (all patch 0-xx) is not so big and smaller as the limit of the mailing list (17k < 40k). What about to send only the complete patch ? It is easier to read for the review.
I made it seperate patches because all changes are seperate from each other. One does not have to install the complete series. Every step should result in a bootable and working driver.
Some other rule says: Keep patches as small as possible...I looked at the complete change at first, but that makes it unreadable, and I believe, harder to review.
Many changes are trivial, only some are more intrusive...
Quoted 8 lines
Quoted 3 lines
There are some issues with the coding style, too (trailing blanks, for example).
hmm, I have configured quilt such that it normally removes those whitespaces... I have to find out what went wrong here.
I only encountered one whitespace issue, in patch 5 and was able to fix it. I use the --whitespace=strip option in git-am, so trailing whitespace isn't a problem.
Quoted 4 lines
Wolfgang, Is the merge window for these patches still open?
If so, I will clean up the patches, and distribute it again in about an hour.
I've applied your patches to the net repo, and since you submitted them by the deadline it should go in this release.