Skip to content

Coldfire Ethernet initialization changes

Ben Warren u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 2 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot-Users] [PATCH 0/2] Coldfire Ethernet initialization changes
Quoted 18 lines · Liew Tsi Chung

Ben,

Quoted 6 lines
Quoted 6 lines
(quoted diff) +5 -1
-#if defined(CONFIG_FSLDMAFEC)
+#if defined(CONFIG_FSLDMAFEC) || #if defined(CONFIG_MCFFEC)
+/* Default initializations for MCFFEC controllers.  To override,
+ * create a board-specific function called:
+ * 	int board_eth_init(bd_t *bis)
+ */
Quoted 9 lines

Review

Quoted 5 lines
(quoted diff) +2 -0
+
 extern int mcdmafec_initialize(bd_t *bis);
+extern int mcffec_initialize(bd_t*);

Does it work after you fix this up?

Quoted 2 lines

Yes.

Great! Thanks for checking it out. I'll update the repo tonight.

regards,
Ben

Read the cover letter in its thread