: VLAN filtering fixes
Status from this message: I've applied Patrick's patches, thanks everyone.
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | : netdrv intel: disable VLAN filtering in promiscous modedrivers/ drivers/ drivers/ +2 more | +57 | 0 replies | |
| 2/2 | : netdrv intel: always enable VLAN filtering except in promiscous modedrivers/ drivers/ drivers/ +2 more | +5 | 0 replies |
Reviews trailers per patch
None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Jeff Kirsher | Peter P Waskiewicz Jr |
|---|---|---|
| Series | A-b | A-b |
| 1/2 | ||
| 2/2 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/2]: VLAN filtering fixes
These two patches contain the last bits of my VLAN + tcpdump fixes. Currently some (all?) drivers have inconsistent behaviour wrt. VLAN filtering and promiscous mode:
They start with disabled VLAN filtering, meaning all VLAN packets are received on packet sockets. When adding the first VLAN, VLAN filtering is enabled and only packets for locally configured VLANs are received, even in promiscous mode. In most cases VLAN filtering is disabled again when removing the last VLAN, igxbe keeps it enabled permanently however.
These patches change the Intel drivers to always enable VLAN filtering while not in promiscous mode since there is little point in receiving VLAN packets while nothing is interested in them, but disable filtering while in promiscous mode so all VLANs are visible to packet sockets.
There are four more drivers that support VLAN filtering that I didn't adapt to this behaviour since I'm not sure about what exactly they currently do. All four of tehuti, starfire, ehea and via-velocity have a flag for the hardware to enable promiscous mode, its unknown to me whether this also automatically disables VLAN filtering. Any information on this someone might have is appreciated.