BUILD_BUG_ON: error on none-const expressions
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest5 patches 24 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 2/5 | net/niu: Fix none-const BUILD_BUG_ON usagedrivers/ | +3 | 0 replies | |
| 3/5 | virtio: Fix none-const BUILD_BUG_ON usageinclude/ | +7 | 0 replies | |
| 3/5 | virtio: Fix non-const BUILD_BUG_ON usageinclude/ | +7 | 0 replies | |
| 4/5 | rt2x00: Compiler warning unmasked by fix of BUILD_BUG_ONdrivers/ | +2 | 2 replies | |
| 4/5 | rt2x00: Compiler warning unmasked by fix of BUILD_BUG_ONdrivers/ | +2 | 5 replies | |
| 4/5 | rt2x00: Compiler warning unmasked by fix of BUILD_BUG_ONdrivers/ | +2 | 0 replies | |
| 5/5 | debug: BUILD_BUG_ON: error on non-const expressionsinclude/ | +4 | 9 replies | |
| 5/5 | debug: BUILD_BUG_ON: error on non-const expressionsinclude/ | +6 | 7 replies |
Reviews trailers per patch
3 of 8 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Ivo van Doorn | Ingo Molnar |
|---|---|---|
| Series | A-b | |
| 2/5 | ||
| 3/5 | ||
| 3/5 | ||
| 4/5 | A-b A-b | |
| 4/5 | A-b A-b | |
| 4/5 | A-b A-b | |
| 5/5 | ||
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCHSET 0/5] BUILD_BUG_ON: error on none-const expressions
Submitted a patchset to fix BUILD_BUG_ON to no longer let through none compile-time constant expressions. This was debated a few times on LKML. The final solution is as proposed by Rusty Russell, which produces all expected results in my tests.
[see: http://www.spinics.net/lists/kernel/msg772904.html]
[PATCH 1/5] debug, x86: move BUILD_BUG_ON() ARRAY_SIZE and __FUNCTION__
Ingo this is your patch. Please verify?
[PATCH 2/5] net/niu: Fix none-const BUILD_BUG_ON usage [PATCH 3/5] virtio: Fix none-const BUILD_BUG_ON usage [PATCH 4/5] rt2x00: Compiler warning unmasked by fix of BUILD_BUG_ON
These three need maintainers approval. I hope I did not forget anyone
[PATCH 5/5] debug: BUILD_BUG_ON: error on none-const expressions
Finally after all call sites are fixed this can go in. (Rusty this one is From: you)
I have only compiled ARCH=x86 (64/32) allmodconfig. So this might break on other ARCHs. It should spend a night in Linux-Next to expose these places.
Thanks
Boaz