x86: ticket spin lock adjustments
Status from this message: applied to tip/x86/spinlocks - thanks Jan!
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | x86: ticket spin locks: fix asm constraintsinclude/ | +3 | 0 replies | |
| 2/3 | x86: ticket spin locks: factor out more common codeinclude/ | +16 | 0 replies | |
| 3/3 | x86: ticket spin locks: reduce instruction dependenciesinclude/ | +7 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/3] x86: ticket spin locks: factor out more common code
Signed-off-by Jan Beulich <[email protected]>
Cc Nick Piggin <[email protected]>
--- include/asm-x86/spinlock.h | 42 ++++++++++++++++-------------------------- 1 file changed, 16 insertions(+), 26 deletions(-)
include/asm-x86/spinlock.h +16 -26
@@ -54,19 +54,7 @@* much between them in performance though, especially as locks are out of line. */ #if (NR_CPUS <256 ) -static inline int __ticket_spin_is_locked (raw_spinlock_t *lock) -{ -int tmp =ACCESS_ONCE (lock->slock); - -return (((tmp >>8 ) &0xff ) != (tmp &0xff )); -} - -static inline int __ticket_spin_is_contended (raw_spinlock_t *lock) -{ -int tmp =ACCESS_ONCE (lock->slock); - -return (((tmp >>8 ) - tmp) &0xff ) >1 ; -} +#define TICKET_SHIFT 8 static __always_inline void __ticket_spin_lock(raw_spinlock_t *lock) {
@@ -116,19 +104,7 @@ static __always_inline void __ticket_spi : "memory", "cc"); }#else -static inline int __ticket_spin_is_locked (raw_spinlock_t *lock) -{ -int tmp =ACCESS_ONCE (lock->slock); - -return (((tmp >>16 ) &0xffff ) != (tmp &0xffff )); -} - -static inline int __ticket_spin_is_contended (raw_spinlock_t *lock) -{ -int tmp =ACCESS_ONCE (lock->slock); - -return (((tmp >>16 ) - tmp) &0xffff ) >1 ; -} +#define TICKET_SHIFT 16 static __always_inline void __ticket_spin_lock(raw_spinlock_t *lock) {
@@ -182,6 +158,20 @@ static __always_inline void __ticket_spi }#endif +static inline int __ticket_spin_is_locked (raw_spinlock_t *lock) +{ +int tmp =ACCESS_ONCE (lock->slock); + +return !!(((tmp >>TICKET_SHIFT ) ^ tmp) & ((1 <<TICKET_SHIFT ) -1 )); +} + +static inline int __ticket_spin_is_contended (raw_spinlock_t *lock) +{ +int tmp =ACCESS_ONCE (lock->slock); + +return (((tmp >>TICKET_SHIFT ) - tmp) & ((1 <<TICKET_SHIFT ) -1 )) >1 ; +} +#ifdef CONFIG_PARAVIRT /* * Define virtualization-friendly old-style lock byte lock, for use in