udevd: Optimize "goto"
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | udevd: trivial cleanup in udev_rules_iterudev/ | +3 | 0 replies | |
| 2/2 | udevd: Avoid repeated scans for goto targets (udev_iter_find_label)udev/ udev/ udev/ | +45 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/2] udevd: Optimize "goto"
I seem to remember you mentioned this as a longer-term goal. This was in the context of the TODO item "rework rules to a match-action list, instead of a rules array".
The idea was to move the scan for the label targeted by a goto rule (udev_rules_iter_label), from run-time to parse-time. It avoids repeating the scan for every event.
I already had a patch for this specific idea. I think it can be implemented now without causing problems. It's no big win - cachegrind suggests it takes 5% off user cpu time - but it is progress.