Skip to content

RFC sata_via: fix TF access and add 8251 support

Tejun Heo linux-ide 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2sata_via: load DEVICE register when CTL changesdrivers/ata/sata_via.c+32 -30 replies
2/2sata_via: fix support for 5287drivers/ata/sata_via.c+142 -120 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/2] sata_via: fix TF access and add 8251 support

Hello, Joseph and Harald.

I'm gonna send two patches as reply to this message. Can you please review them? Both are separated out from Joseph's original patch.

http://thread.gmane.org/gmane.linux.kernel.commits.mm/40640

The former one (fix TF load) is rather straight-forward and it seems to work on my vt6421's but I couldn't test 8251 support as I don't have any. I thought the controller you sent me was 8251 but it was 6421, right? I think I asked for 6421 not knowing what I wanted was 8251. So, it would be great if you can test whether the 8251 support works. Please post the kernel log whether it succeeds or not.

For the time being, I skipped support for 0581 and 5324 as they were not on the PCI device ID list of the original patch. Do they have the same configuration? Or are they SATA/PATA mixed?

The patches are on top of the upstream branch of Jeff's libata-dev tree.

git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
http://www.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git

Thanks.

Signature · 1 line
tejun