Skip to content

mm: rework sys_move_pages() to avoid vmalloc and reduce the overhead

Brice Goglin linux-mm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5mm: stop returning -ENOENT from sys_move_pages() if nothing got migratedmm/migrate.c+1 -21 reply
2/5mm: don't vmalloc a huge page_to_node array for do_pages_stat()mm/migrate.c+25 -151 reply
3/5mm: extract do_pages_move() out of sys_move_pages()mm/migrate.c+86 -661 reply
4/5mm: rework do_pages_move() to work on page_sized chunksmm/migrate.c+44 -354 replies
5/5mm: move_pages: no need to set pp->page to ZERO_PAGE(0) by defaultmm/migrate.c+0 -61 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchChristoph Lameter
1/5A-b
2/5A-b
3/5A-b
4/5A-b A-b
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] mm: rework sys_move_pages() to avoid vmalloc and reduce the overhead

Hello,

Here's the first patchset reworking sys_move_pages() as discussed earlier. It removes the possibly large vmalloc by using multiple chunks when migrating large buffers. It also dramatically increases the throughput for large buffers since the lookup in new_page_node() is now limited to a single chunk, causing the quadratic complexity to have a much slower impact. There is no need to use any radix-tree-like structure to improve this lookup.

sys_move_pages() duration on a 4-quadcore-opteron 2347HE (1.9Gz), migrating between nodes #2 and #3:

	length		move_pages (us)		move_pages+patch (us)
	4kB		126			98
	40kB		198			168
	400kB		963			937
	4MB		12503			11930
	40MB		246867			11848

Patches #1 and #4 are the important ones:
1) stop returning -ENOENT from sys_move_pages() if nothing got migrated
2) don't vmalloc a huge page_to_node array for do_pages_stat()
3) extract do_pages_move() out of sys_move_pages()
4) rework do_pages_move() to work on page_sized chunks
5) move_pages: no need to set pp->page to ZERO_PAGE(0) by default

thanks,
Brice

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>