Skip to content

x86 / intel_pstate: Set asymmetric CPU capacity on hybrid systems

Rafael J. Wysocki linux-pm lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 11 repliesIn review
  2. v23 patches 6 repliesSuperseded
  3. v13 patches 0 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2x86/sched: Add basic support for CPU capacity scalingarch/x86/include/asm/topology.h arch/x86/kernel/cpu/aperfmperf.c+100 -23 replies
2/2cpufreq: intel_pstate: Set asymmetric CPU capacity on hybrid systemsdrivers/cpufreq/intel_pstate.c+228 -46 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchPeter Zijlstra (Intel)Ricardo Neri
SeriesT-b
1/2A-b R-b T-b
2/2R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] x86 / intel_pstate: Set asymmetric CPU capacity on hybrid systems

Hi Everyone,

This is an update of

https://lore.kernel.org/linux-pm/[email protected]/

which was an update of

https://lore.kernel.org/linux-pm/[email protected]/

It addresses Ricardo's review comments and fixes an issue with intel_pstate operation mode changes that would cause it to attempt to enable hybrid CPU capacity scaling after it has been already enabled during initialization.

The most visible difference with respect to the previous version is that patch [1/3] has been dropped because it is not needed any more after using the observation that sched_clear_itmt_support() would cause sched domains to be rebuilt.

Other than this, there are cosmetic differences in patch [1/2] (previously [2/3]) and the new code in intel_pstate_register_driver() in patch [2/2] (previously [3/3]) has been squashed into hybrid_init_cpu_scaling() which now checks whether or not to enable hybrid CPU capacity scaling (as it may have been enabled already).

This series is available from the following git branch:

https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/log/?h=intel_pstate-testing

(with an extra debug commit on top).

The original cover letter quoted below still applies:

The purpose of this series is to provide the scheduler with asymmetric CPU capacity information on x86 hybrid systems based on Intel hardware.

The asymmetric CPU capacity information is important on hybrid systems as it allows utilization to be computed for tasks in a consistent way across all CPUs in the system, regardless of their capacity. This, in turn, allows the schedutil cpufreq governor to set CPU performance levels consistently in the cases when tasks migrate between CPUs of different capacities. It should also help to improve task placement and load balancing decisions on hybrid systems and it is key for anything along the lines of EAS.

The information in question comes from the MSR_HWP_CAPABILITIES register and is provided to the scheduler by the intel_pstate driver, as per the changelog of patch [3/3]. Patch [2/3] introduces the arch infrastructure needed for that (in the form of a per-CPU capacity variable) and patch [1/3] is a preliminary code adjustment.

This is based on an RFC posted previously

https://lore.kernel.org/linux-pm/7663799.EvYhyI6sBW@kreacher/

but differs from it quite a bit (except for the first patch). The most significant difference is based on the observation that frequency- invariance needs to adjusted to the capacity scaling on hybrid systems for the complete scale-invariance to work as expected.

Thank you!