net: Additional IP fragmentation check
Get series with b4
b4 am [email protected]Versions newest first
- v2 Latest0 of 2 patches 0 repliesNew
Patches in v2 No applies recorded yet
None of the 2 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [U-Boot] [PATCH v2 0/2] net: Additional IP fragmentation check
Hi Peter,
Quoted 26 lines · Peter Tyser
v2: Forgot SOBs...
It looks like U-Boot ignores fragmented IP packets with non-zero "fragment offset" fields, but doesn't ignore the initial fragmented IP packet which has a "fragment offset" field value of 0.
An additional check was added to catch the initial fragmented packet which should have the "more fragments" bit set in its flags field.
The bug initially resulted in TFTP transfers which appeared to work, but in reality failed as some fragmented packets were received, others were not. With these patches applied a TFTP download from a server with a low MTU results in a timeout as U-Boot drops all incominig fragmented TFTP data packets.
I quickly tried the "Add simple IP/UDP fragmentation support" patch in the net/testing repository, but it did not work out of the box. It looks like U-Boot was assembling the fragmented packets correctly based on a memory display of &NetFragBuf, but the assembled packet was not making its way up the stack FWIW.
Quoted 8 lines
Peter Tyser (2):
net: Define IP flag field values
net: Add additional IP fragmentation checkinclude/net.h | 6 ++++++ net/net.c | 8 +++++--- 2 files changed, 11 insertions(+), 3 deletions(-)
Patches 1 and 2 applied to net repo.
thanks,
Ben