Skip to content

tlan: fix earlier fixes, remove big buffer mode

Sakari Ailus netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2tlan: Fix pci memory unmappingdrivers/net/tlan.c+9 -40 replies
2/2tlan: Remove broken support for big buffersdrivers/net/tlan.c+77 -1340 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] tlan: fix earlier fixes, remove big buffer mode

Hi,

Unfortunately it seems that my last patch introduced a few problems.

So here are two patches: the first one fixes the pci memory unmapping. The second one removes the big buffer mode.

That mode has never worked for me and I've been using tlan cards since 2001 or so. With Google I could find one case where someone claimed it was working on 2.4.0-test1-ac7. ;-)

<URL:http://lkml.indiana.edu/hypermail/linux/kernel/0006.0/0193.html>

There's another (likely) bug in the bbuf mode (think skb copying there by txlen bytes), introduced by my earlier patch, which is fixed by the second patch by removing the mode altogether.

Cheers,

Signature · 2 lines
Sakari Ailus
[email protected]