Skip to content

sym53c8xx fixes

Tony Battersby linux-scsi 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7sym53c8xx: fix shost use-after-free and memory leakdrivers/scsi/sym53c8xx_2/sym_glue.c+1 -10 replies
2/7sym53c8xx: fix NULL deref on error pathdrivers/scsi/sym53c8xx_2/sym_glue.c+1 -10 replies
3/7sym53c8xx: fix bogus free_irq() on error pathdrivers/scsi/sym53c8xx_2/sym_glue.c+7 -40 replies
4/7sym53c8xx: unmap pci memory after probe errorsdrivers/scsi/sym53c8xx_2/sym_glue.c+41 -250 replies
5/7sym53c8xx: handle pci_iomap() failuresdrivers/scsi/sym53c8xx_2/sym_glue.c+36 -260 replies
6/7sym53c8xx: use a queue depth of 1 for untagged devicesdrivers/scsi/sym53c8xx_2/sym_glue.c+4 -40 replies
7/7sym53c8xx: don't flood syslog with negotiation messagesdrivers/scsi/sym53c8xx_2/sym_hipd.c drivers/scsi/sym53c8xx_2/sym_hipd.h+29 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7] sym53c8xx fixes

James, please consider these patches for inclusion in 2.6.29 or 2.6.30.

Patches 1 - 5 fix bugs found when auditing the error paths of sym53c8xx during module load and unload. These 5 patches must be applied in the order given, since they touch the same areas of the same file. Patches 6 and 7 fix other problems and annoyances, and can be applied in any order.

In addition, here are some related patches by other people that I would like applied:

The following patch fixes handling of errors that occur after scsi_host_alloc() during modprobe sym53c8xx. I actually came up with the same fix myself when auditing sym53c8xx, but a search of linux-scsi showed that someone else had already gotten there first. [PATCH] SCSI: fix /proc memory leak in the SCSI core
http://marc.info/?t=122814541000002&r=1&w=4

The following patch was posted a year ago but forgotten. I have been using it for a long time, and it still applies cleanly. sym53c8xx ISTAT1 feature never set
http://marc.info/?t=120076464500006&r=1&w=4

And of course there are the recent patches by Aaro Koskinen:

Tested with my approval (be sure to use the updated version):
[PATCH] sym53c8xx_2: slave_alloc/destroy safety (2.6.27.5)
http://marc.info/?t=122710678100001&r=1&w=4

Tested with my approval:
[PATCH] sym53c8xx_2: lun to_clear flag not re-initialized (2.6.27.5)
http://marc.info/?t=122710178300003&r=1&w=4

This one however still needs some work (as of this writing):
[PATCH] sym53c8xx_2: Keep transfer negotiations valid (2.6.27.5)
http://marc.info/?t=122710118300005&r=1&w=4

Thanks,
Tony Battersby
Cybernetics