Skip to content

ocfs2: Inode Allocation Strategy Improvement.v2

Sunil Mushran ocfs2-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 3 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 3 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Ocfs2-devel] [PATCH 0/3] ocfs2: Inode Allocation Strategy Improvement.v2

:)

Quoted 138 lines · tristan.ye
Quoted 3 lines · Sunil Mushran

Good numbers. Did you a 2nd rm -rf too? It should show the largest improvement of all.

Yes, fairly cool, we also got up to 3 mins performance gain during 2nd rm -rf test:

=============== Tests with 10 times iteration================
2nd 'rm -rf' result:

Average real time with 10 times:
Original kernel kernel with enhanced patches
4m3.425ss 0m59.423ss

Regards,
Tristan

Quoted 113 lines · tristan.ye
Quoted 112 lines · Tao Ma
Quoted 43 lines
Quoted 23 lines · tristan.ye
Quoted 5 lines · Sunil Mushran

How big is this disk? Maybe one kernel tree untar is not be enough to
expose the original issue. Also, use ls -i and/or debugfs to see if the inodes have some locality.

Tao, sunil

I've tested it out with more attempts, it may have something to do with
the disk size. but the root pause why i did not get a excited speed-up
performance gain was due to the iscsi-target(iscsi server) cache. the
operation in your testcase which was meant for cache dropping is aimed
at client side(a 'echo 2>/proc/sys/vm/drop_cache' only flush the fs's
cache for iscsi initor(isci client)).

Tao,

Quoted 8 lines

You can verify this by pausing the tests at the right point before we
start '2rd ls -lR', then flush the iscsi-target's cache by 'service iscsi-target restart'(there may be a more graceful way to do this),after
this done, resume the tests, then you'll find the the realtime it consumed will be up to 3 mins around:)

cool, so I am very glad that you got the same result as mine. ;)

Quoted 7 lines

Btw, i really saw lots of locality by 'ls -li' for inodes under a same
dir, take /mnt/ocfs2/linux-2.6.28/include/linux for instance, almost all
of its inodes are contiguous one by one regarding to its inode number.

Quoted 4 lines

yeah, that is the desired behaviour with my 3 patches. :)

Then do you have any updated test statistics?

Tao,

With iscsi-target cache flushed everytime before tests getting started,
following is the updated testing result:

Testing node:test7
Testing volume: iscsi sdd1

=============== Tests with 10 times iteration================

1st 'Tar xjvf' result:

Average real time with 10 times:
Original kernel kernel with enhanced
patches
0m 22.468s 0m 23.472s

1st 'ls -lR' result:
Average real time with 10 times:
Original kernel kernel with enhanced
patches
0m 30.682s 0m 30.414s

1st 'rm -rf' result:
Average real time with 10 times:
Original kernel kernel with enhanced
patches
0m 1m5.715s 0m 1m3.835s

2rd 'Tar xjvf' result:
Average real time with 10 times:
Original kernel kernel with enhanced
patches
0m 31.550s 0m 28.726s

2rd 'ls -lR' result:
Average real time with 10 times:
Original kernel kernel with enhanced
patches

0m 3m5.772s 0m 30.274s

===============Tests end============================

Glad to see your guy's patch has greatly improved the performance of inodes traversing:),

Unfortunately, the 1st Tar testcase still get a performance penality(around 1s) everytime.

I've kept the testing env on test7 for your verification.

Regards,

Tristan

Quoted 3 lines

Regards,
Tao