Skip to content

ocfs2: two bug fixes about xattr and inline-data

Tiger Yang ocfs2-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ocfs2: reserve xattr block for directory inode in mknodfs/ocfs2/xattr.c+1 -01 reply
2/2ocfs2: fix check condition of max inline datafs/ocfs2/aops.c+4 -11 reply
2/2ocfs2: fix check condition of max inline data+0 -02 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Ocfs2-devel] [PATCH 0/2] ocfs2: two bug fixes about xattr and inline-data

Mark and Joel,

I found two serious bugs about xattr and inline-data.

the first bug:
in ocfs2_mknod(), we check and found the ACL or security xattr entry could be set into inode in ocfs2_calc_xattr_init(), then don't reserve block for them. But in ocfs2_mknod_locked(), if we found ocfs2 support inline-data, then set id_count with the max_inline_data. After that, we set acl/security xattr entry in ocfs2_init_acl() or ocfs2_init_security_set(), but in there we found inode is full, then panic at ocfs2_claim_metadata in ocfs2_xattr_block_set.

the second bug:
we don't check inline xattr in ocfs2_try_to_write_inline_data(), so the inline data may overwrite the xattr entries which have already in inode.

thanks,
tiger