Skip to content

ocfs2: two bug fixes about xattr and inline-data

Tiger Yang ocfs2-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 2 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Ocfs2-devel] [PATCH 0/2] ocfs2: two bug fixes about xattr and inline-data

Hi, all,

Finally, Tristan and I found the reason why he could not reproduce bug2. It's very interesting.

He runs the command "dd if=/dev/zero of=testfile bs=1 count=3641" which can not hit the bug2. But I found "dd if=/dev/zero of=testfile bs=3641 count=1" will hit the bug2.

I trace the source code in ocfs2_try_to_write_inline_data(). Those two commands run the different way in kernel. In first situation, the codes going into "handle inodes which already have inline data 1st", then fault at ocfs2_size_fits_inline_data(), then go ocfs2_conver_inline_data_to_extents(). In second situation, It passed the wrong check about inline data size: ocfs2_max_inline_data(), then cause the fault.

As we discussed, Tristan will add the new command into his test script. Meanwhile he will reserve the old one because it cover more codes.

thanks,
tiger

Quoted 45 lines · Tiger Yang

Hi,

I think Tristan's test script could catch these two bugs against mainline. He didn't run his test script in mainline yet.

bug1:
Just create a file in a directory which has default ACLs.

bug2:
1. touch a file in a file system which blocksize large than 512.
2. set xattr in it.
3. write i_size > (MAX_INLINE_SIZE - 256).
then you can find the inline data overwrite the xattr in inode.

thanks,
tiger

Quoted 6 lines · Tao Ma

Hi Tiger,
so could you please describe how to reproduce these 2 bugs step by
step? It would be easy for tristan to code them down and add them to the test case. And also we all can see whether we can reproduce them in our own env.

Quoted 16 lines

Regards,
Tao

Quoted 12 lines · tristan.ye
Quoted 4 lines · Joel Becker
Quoted 1 line · Tiger Yang

I found these two bugs in latest mainline kernel not other branch.

The bugs should still be in cacheme - cacheme doesn't change
the inline data code.

Fairly strange, I've already done the tests on cacheme branch, no such bugs happened to me...

Tristan

Quoted 2 lines

Joel

_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel at oss.oracle.com
http://oss.oracle.com/mailman/listinfo/ocfs2-devel