Skip to content

blktrace: various cleanups and fixes

Li Zefan lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 31 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7blktrace: fix possible memory leakkernel/trace/blktrace.c+1 -13 replies
2/7blktrace: make blk_tracer_enabled a bool flagkernel/trace/blktrace.c+3 -94 replies
3/7blktrace: remove blk_probe_mutexkernel/trace/blktrace.c+5 -226 replies
4/7blktrace: don't increase blk_probes_ref if failed to setup blk tracekernel/trace/blktrace.c+3 -33 replies
5/7blktrace: report EBUSY correctlykernel/trace/blktrace.c+3 -64 replies
6/7blktrace: remove sysfs_blk_trace_enable_show/store()kernel/trace/blktrace.c+21 -684 replies
7/7blktrace: avoid accessing NULL bdev->bd_diskkernel/trace/blktrace.c+11 -24 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchFrederic WeisbeckerArnaldo Carvalho de MeloSteven Rostedt
SeriesA-b
1/7A-b A-b A-b A-b
2/7A-b A-b A-b A-b
3/7A-b A-b A-b
4/7A-b A-b A-b A-b
5/7A-b A-b A-b A-b
6/7A-b A-b A-b A-b
7/7A-b A-b A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/7] blktrace: various cleanups and fixes

While trying to use blktrace in -tip tree, I encounted kernel NULL dereference, so I looked into the code, and then found some other bugs.

This patchset is part 1, and I have some other pending fixes.

Each patch is small and straightforward, and should be easy to review:

[PATCH 1/7] blktrace: fix possible memory leak
[PATCH 2/7] blktrace: make blk_tracer_enabled a bool flag
[PATCH 3/7] blktrace: remove blk_probe_mutex
[PATCH 4/7] blktrace: don't increase blk_probes_ref if failed to setup blk trace [PATCH 5/7] blktrace: report EBUSY correctly
[PATCH 6/7] blktrace: remove sysfs_blk_trace_enable_show/store() [PATCH 7/7] blktrace: avoid accessing NULL bdev->bd_disk

---
 blktrace.c |  154 +++++++++++++++++--------------------------------------------
 1 file changed, 45 insertions(+), 109 deletions(-)