Skip to content

nfs41 client patch for 2.6.30

Benny Halevy linux-nfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest67 patches 4 repliesIn review

Changes in v2 from the cover letter

- fixed bisectability issues
- got rid of rpc_clnt.cl_private, use *session in seq args/res instead
- remove ifdefs around nfs_client_initdata.minorversion
- use kcalloc to allocate slot table
- alloc session with GFP_KERNEL
- moved nfs4_init_slot_table's definition from "sessions client infrastructure" to first usage, in "create_session operations".
- embed resp_len in nfs_getaclres
- moved new xdr op args/res definitions away from "client xdr definitions", to where they're first used.
- move find_slot and free_slot closer to where they're first used.
- Revert "NFS: fix decode_fs_locations_maxsz"
- nfs41: get fs_locations replen before encoding the GETATTR
- nfs41: get getacl replen before encoding the GETATTR

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/67nfs41: common protocol definitionsinclude/linux/nfs4.h+127 -11 reply
2/67nfs41: Add Kconfig symbols for NFSv4.1fs/nfs/Kconfig+9 -00 replies
3/67nfs41: define NFS4_MAX_MINOR_VERSION based on CONFIG_NFS_V4_1include/linux/nfs4.h+7 -00 replies
4/67nfs41: add mount command option minorversionfs/nfs/internal.h fs/nfs/super.c+11 -00 replies
5/67nfs41: nfs_client.cl_minorversionfs/nfs/client.c include/linux/nfs_fs_sb.h+8 -40 replies
6/67nfs41: Use mount minorversion optionfs/nfs/client.c+6 -10 replies
7/67nfs41: translate NFS4ERR_MINOR_VERS_MISMATCH to EPROTONOSUPPORTfs/nfs/nfs4state.c+2 -00 replies
8/67nfs41: client xdr definitionsinclude/linux/nfs_xdr.h+52 -00 replies
9/67nfs41: sessions client infrastructurefs/nfs/client.c fs/nfs/internal.h fs/nfs/nfs4_fs.h +3 more+174 -00 replies
10/67nfs41: use nfs4_server_caps_argfs/nfs/nfs4proc.c fs/nfs/nfs4xdr.c include/linux/nfs_xdr.h+12 -30 replies
11/67nfs41: use nfs4_readlink_resfs/nfs/nfs4proc.c fs/nfs/nfs4xdr.c include/linux/nfs_xdr.h+8 -20 replies
12/67nfs41: use nfs4_statfs_resfs/nfs/nfs4proc.c fs/nfs/nfs4xdr.c include/linux/nfs_xdr.h+12 -30 replies
13/67nfs41: use nfs4_fsinfo_resfs/nfs/nfs4proc.c fs/nfs/nfs4xdr.c include/linux/nfs_xdr.h+12 -30 replies
14/67nfs41: use nfs4_pathconf_resfs/nfs/nfs4proc.c fs/nfs/nfs4xdr.c include/linux/nfs_xdr.h+12 -30 replies
15/67nfs41: use nfs4_getaclresfs/nfs/nfs4proc.c fs/nfs/nfs4xdr.c include/linux/nfs_xdr.h+19 -110 replies
16/67NFS: get rid of unused xdr decode_setattr(, res) argumentfs/nfs/nfs4xdr.c+3 -30 replies
17/67nfs41: use nfs4_setaclresfs/nfs/nfs4proc.c fs/nfs/nfs4xdr.c include/linux/nfs_xdr.h+8 -20 replies
18/67nfs41: use nfs4_fs_locations_resfs/nfs/nfs4proc.c fs/nfs/nfs4xdr.c include/linux/nfs_xdr.h+13 -30 replies
19/67nfs41: introduce nfs4_call_syncfs/nfs/client.c fs/nfs/internal.h fs/nfs/nfs4proc.c +1 more+73 -190 replies
20/67nfs41: nfs41: pass *session in seq_args and seq_resfs/nfs/nfs4proc.c include/linux/nfs_xdr.h+3 -20 replies
21/67nfs41: set up seq_res.sr_slotidfs/nfs/nfs4proc.c fs/nfs/read.c fs/nfs/unlink.c +2 more+10 -00 replies
22/67NFS: use decode_change_info_maxsz for xdr maxsz calculationsfs/nfs/nfs4xdr.c+7 -30 replies
23/67NFS: define and initialize compound_hdr.replenfs/nfs/nfs4xdr.c+43 -340 replies
24/67NFS: update hdr->replen for every encode opfs/nfs/nfs4xdr.c+31 -00 replies
25/67NFS: use dynamically computed compound_hdr.replen for xdr_inline_pages offsetfs/nfs/nfs4xdr.c+10 -380 replies
26/67nfs41: encode minorversion in compound headerfs/nfs/nfs4xdr.c+40 -300 replies
27/67nfs41: xdr {encode,decode}_sequencefs/nfs/nfs4xdr.c+232 -100 replies
28/67nfs41: nfs4_setup_sequencefs/nfs/nfs4proc.c+98 -20 replies
29/67nfs41: find slotfs/nfs/nfs4proc.c+33 -00 replies
30/67nfs41: setup_sequence methodfs/nfs/nfs4_fs.h fs/nfs/nfs4proc.c include/linux/nfs_xdr.h+46 -20 replies
31/67nfs41: free slotfs/nfs/nfs4proc.c+36 -00 replies
32/67nfs41: nfs41_sequence_free_slotfs/nfs/internal.h fs/nfs/nfs4proc.c+35 -00 replies
33/67nfs41: nfs41_sequence_donefs/nfs/nfs4proc.c+58 -00 replies
34/67nfs41: nfs41_call_sync_donefs/nfs/nfs4proc.c+9 -00 replies
35/67nfs41: close sequence setup/done supportfs/nfs/nfs4proc.c+7 -10 replies
36/67nfs41: open sequence setup/done supportfs/nfs/nfs4proc.c+8 -00 replies
37/67nfs41: lock sequence setup/done supportfs/nfs/nfs4proc.c+8 -00 replies
38/67nfs41: locku sequence setup/done supportfs/nfs/nfs4proc.c+9 -10 replies
39/67nfs41: unlink sequence setup/done supportfs/nfs/nfs4proc.c fs/nfs/unlink.c+19 -00 replies
40/67nfs41: read sequence setup/done supportfs/nfs/direct.c fs/nfs/internal.h fs/nfs/nfs4proc.c +1 more+39 -20 replies
41/67nfs41 write sequence setup done supportfs/nfs/direct.c fs/nfs/internal.h fs/nfs/nfs4proc.c +1 more+32 -00 replies
42/67nfs41 commit sequence setup done supportfs/nfs/direct.c fs/nfs/nfs4proc.c fs/nfs/write.c+10 -00 replies
43/67nfs41 delegreturn sequence setup done supportfs/nfs/nfs4proc.c+23 -10 replies
44/67nfs41: exchange_id operationfs/nfs/nfs4proc.c fs/nfs/nfs4xdr.c include/linux/nfs4.h +3 more+252 -10 replies
45/67nfs41: get_lease_timefs/nfs/nfs4proc.c fs/nfs/nfs4xdr.c include/linux/nfs_xdr.h+154 -00 replies
46/67nfs41: create_session operationfs/nfs/nfs4proc.c fs/nfs/nfs4xdr.c include/linux/nfs4.h +1 more+383 -00 replies
47/67nfs41: verify session channel attribuesfs/nfs/nfs4proc.c+48 -20 replies
48/67nfs41: use session attributes for rsize and wsizefs/nfs/client.c+17 -00 replies
49/67nfs41: destroy_session operationfs/nfs/nfs4proc.c fs/nfs/nfs4xdr.c fs/nfs/super.c+91 -00 replies
50/67nfs41: enable nfs_client only nfs4_async_handle_errorfs/nfs/nfs4proc.c+9 -40 replies
51/67nfs41: sequence operationfs/nfs/nfs4proc.c fs/nfs/nfs4xdr.c+214 -50 replies
52/67nfs41: reset the session slot tablefs/nfs/nfs4proc.c+41 -30 replies
53/67nfs41: add session setup to the state managerfs/nfs/client.c fs/nfs/internal.h fs/nfs/nfs4_fs.h +3 more+54 -50 replies
54/67nfs41: add session reset to state managerfs/nfs/nfs4_fs.h fs/nfs/nfs4state.c+50 -20 replies
55/67nfs41: sunrpc: Export the call prepare state for session resetinclude/linux/sunrpc/clnt.h include/linux/sunrpc/sched.h net/sunrpc/clnt.c +1 more+16 -10 replies
56/67nfs41: use rpc prepare call state for session resetfs/nfs/internal.h fs/nfs/nfs4proc.c fs/nfs/read.c +2 more+30 -130 replies
57/67nfs41: kick start nfs41 session recovery when handling errorsfs/nfs/nfs4proc.c+32 -00 replies
58/67nfs41: schedule async session resetfs/nfs/nfs4proc.c+34 -00 replies
59/67nfs41: lease renewalfs/nfs/nfs4_fs.h fs/nfs/nfs4proc.c fs/nfs/nfs4renewd.c+33 -10 replies
60/67nfs41: support minorversion 1 for nfs4_check_leasefs/nfs/nfs4_fs.h fs/nfs/nfs4proc.c fs/nfs/nfs4state.c+6 -10 replies
61/67nfs41: introduce get_state_renewal_credfs/nfs/nfs4_fs.h fs/nfs/nfs4proc.c fs/nfs/nfs4renewd.c +1 more+14 -140 replies
62/67nfs41: establish sessions-based clientidfs/nfs/nfs4_fs.h fs/nfs/nfs4proc.c fs/nfs/nfs4state.c+50 -80 replies
63/67nfs41: add a get_clid_cred function to nfs4_state_recovery_opsfs/nfs/nfs4_fs.h fs/nfs/nfs4proc.c fs/nfs/nfs4state.c+4 -10 replies
64/67nfs41: get_clid_cred for EXCHANGE_IDfs/nfs/nfs4_fs.h fs/nfs/nfs4proc.c fs/nfs/nfs4state.c+17 -00 replies
65/67nfs41: recover lease in _nfs4_lookup_rootfs/nfs/nfs4proc.c+6 -10 replies
66/67nfs41: fail mount on EXCHANGE_ID, CREATE_SESSION failurefs/nfs/client.c fs/nfs/internal.h fs/nfs/nfs4proc.c+19 -00 replies
67/67nfs41: increment_{open,lock}_seqidfs/nfs/nfs4proc.c fs/nfs/nfs4state.c+9 -50 replies

Reviews trailers per patch

1 of 67 patches has a Reviewed-by or Acked-by.

PatchJ. Bruce Fields
1/67A-b
2/67
3/67
4/67
5/67
6/67
7/67
8/67
9/67
10/67
11/67
12/67
13/67
14/67
15/67
16/67
17/67
18/67
19/67
20/67
21/67
22/67
23/67
24/67
25/67
26/67
27/67
28/67
29/67
30/67
31/67
32/67
33/67
34/67
35/67
36/67
37/67
38/67
39/67
40/67
41/67
42/67
43/67
44/67
45/67
46/67
47/67
48/67
49/67
50/67
51/67
52/67
53/67
54/67
55/67
56/67
57/67
58/67
59/67
60/67
61/67
62/67
63/67
64/67
65/67
66/67
67/67

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/67] nfs41 client patch for 2.6.30

Trond,

I've integrated the latest client patches from Andy (with a few minor changes listed below) and updated
git://linux-nfs.org/~bhalevy/linux-pnfs.git
branches:

	nfs41-for-next
	nfs41-for-2.6.30
	nfs41

nfs41-for-{next,2.6.30} contain all non-backchannel patches rebased onto {v2.6.29,nfs-2.6/for-next} respectively.

nfs41 contains the backchannel patches on top of nfs41-for-2.6.30.

changes since v1:
- fixed bisectability issues
- got rid of rpc_clnt.cl_private, use *session in seq args/res instead
- remove ifdefs around nfs_client_initdata.minorversion
- use kcalloc to allocate slot table
- alloc session with GFP_KERNEL
- moved nfs4_init_slot_table's definition from "sessions client infrastructure" to first usage, in "create_session operations".
- embed resp_len in nfs_getaclres
- moved new xdr op args/res definitions away from "client xdr definitions", to where they're first used.
- move find_slot and free_slot closer to where they're first used.
- Revert "NFS: fix decode_fs_locations_maxsz"
- nfs41: get fs_locations replen before encoding the GETATTR
- nfs41: get getacl replen before encoding the GETATTR

(changes from Andy's set)
- getaclres moved into right patch
- dropped "nfs41: stubs for nfs41 procedures"
- edited create_session, destroy_session, session setup, and session_reset for proc_{create,destroy}_session interface.
- reverse EXCHGID4_INVAL_FLAG_MASK_{A,R}

Here's the list of patches:

[PATCH v2 01/67] nfs41: common protocol definitions
[PATCH v2 02/67] nfs41: Add Kconfig symbols for NFSv4.1
[PATCH v2 03/67] nfs41: define NFS4_MAX_MINOR_VERSION based on CONFIG_NFS_V4_1 [PATCH v2 04/67] nfs41: add mount command option minorversion
[PATCH v2 05/67] nfs41: nfs_client.cl_minorversion
[PATCH v2 06/67] nfs41: Use mount minorversion option
[PATCH v2 07/67] nfs41: translate NFS4ERR_MINOR_VERS_MISMATCH to EPROTONOSUPPORT [PATCH v2 08/67] nfs41: client xdr definitions
[PATCH v2 09/67] nfs41: sessions client infrastructure
[PATCH v2 10/67] nfs41: use nfs4_server_caps_arg
[PATCH v2 11/67] nfs41: use nfs4_readlink_res
[PATCH v2 12/67] nfs41: use nfs4_statfs_res
[PATCH v2 13/67] nfs41: use nfs4_fsinfo_res
[PATCH v2 14/67] nfs41: use nfs4_pathconf_res
[PATCH v2 15/67] nfs41: use nfs4_getaclres
[PATCH v2 16/67] NFS: get rid of unused xdr decode_setattr(, res) argument [PATCH v2 17/67] nfs41: use nfs4_setaclres
[PATCH v2 18/67] nfs41: use nfs4_fs_locations_res
[PATCH v2 19/67] nfs41: introduce nfs4_call_sync
[PATCH v2 20/67] nfs41: nfs41: pass *session in seq_args and seq_res
[PATCH v2 21/67] nfs41: set up seq_res.sr_slotid
[PATCH v2 22/67] NFS: use decode_change_info_maxsz for xdr maxsz calculations [PATCH v2 23/67] NFS: define and initialize compound_hdr.replen
[PATCH v2 24/67] NFS: update hdr->replen for every encode op
[PATCH v2 25/67] NFS: use dynamically computed compound_hdr.replen for xdr_inline_pages offset [PATCH v2 26/67] nfs41: encode minorversion in compound header
[PATCH v2 27/67] nfs41: xdr {encode,decode}_sequence
[PATCH v2 28/67] nfs41: nfs4_setup_sequence
[PATCH v2 29/67] nfs41: find slot
[PATCH v2 30/67] nfs41: setup_sequence method
[PATCH v2 31/67] nfs41: free slot
[PATCH v2 32/67] nfs41: nfs41_sequence_free_slot
[PATCH v2 33/67] nfs41: nfs41_sequence_done
[PATCH v2 34/67] nfs41: nfs41_call_sync_done
[PATCH v2 35/67] nfs41: close sequence setup/done support
[PATCH v2 36/67] nfs41: open sequence setup/done support
[PATCH v2 37/67] nfs41: lock sequence setup/done support
[PATCH v2 38/67] nfs41: locku sequence setup/done support
[PATCH v2 39/67] nfs41: unlink sequence setup/done support
[PATCH v2 40/67] nfs41: read sequence setup/done support
[PATCH v2 41/67] nfs41 write sequence setup done support
[PATCH v2 42/67] nfs41 commit sequence setup done support
[PATCH v2 43/67] nfs41 delegreturn sequence setup done support
[PATCH v2 44/67] nfs41: exchange_id operation
[PATCH v2 45/67] nfs41: get_lease_time
[PATCH v2 46/67] nfs41: create_session operation
[PATCH v2 47/67] nfs41: verify session channel attribues
[PATCH v2 48/67] nfs41: use session attributes for rsize and wsize
[PATCH v2 49/67] nfs41: destroy_session operation
[PATCH v2 50/67] nfs41: enable nfs_client only nfs4_async_handle_error
[PATCH v2 51/67] nfs41: sequence operation
[PATCH v2 52/67] nfs41: reset the session slot table
[PATCH v2 53/67] nfs41: add session setup to the state manager
[PATCH v2 54/67] nfs41: add session reset to state manager
[PATCH v2 55/67] nfs41: sunrpc: Export the call prepare state for session reset [PATCH v2 56/67] nfs41: use rpc prepare call state for session reset
[PATCH v2 57/67] nfs41: kick start nfs41 session recovery when handling errors [PATCH v2 58/67] nfs41: schedule async session reset
[PATCH v2 59/67] nfs41: lease renewal
[PATCH v2 60/67] nfs41: support minorversion 1 for nfs4_check_lease
[PATCH v2 61/67] nfs41: introduce get_state_renewal_cred
[PATCH v2 62/67] nfs41: establish sessions-based clientid
[PATCH v2 63/67] nfs41: add a get_clid_cred function to nfs4_state_recovery_ops [PATCH v2 64/67] nfs41: get_clid_cred for EXCHANGE_ID
[PATCH v2 65/67] nfs41: recover lease in _nfs4_lookup_root
[PATCH v2 66/67] nfs41: fail mount on EXCHANGE_ID, CREATE_SESSION failure [PATCH v2 67/67] nfs41: increment_{open,lock}_seqid