nfsstat: Fixing and improving the new --sleep and --list options
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 4 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | nfsstat: The --list option does not work on server stats.utils/ | +80 | 0 replies | |
| 2/3 | nfsstat: -Z showing incorrect server statsutils/ | +5 | 0 replies | |
| 3/3 | nfsstat: Eliminate the displaying zero statsutils/ | +135 | 4 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/3] nfsstat: Fixing and improving the new --sleep and --list options
Using the new --sleep and --list options to nfsstats, I found a server side bug and an annoyance when particular protocols where specified.
When the --sleep options as used with a particular protocol option (i.e. -2, -3 or -4) and there was no traffic, blank lines were being echoed to the screen causing useful data to be scrolled of the screen.
Also with the --sleep option, the server stats were not being updated which meant the same values would be echoed again and again when there was not new server traffic.
Finally when using the --sleep and/or --list options, zero stats will not be displayed. I found it much more useful to show what happen instead of showing what did not happen. Plus not showing zero stats makes the --list much easier to read and digest as well as keeping useful data from scrolling off the screen.
The server side bug was the fact --list didn't on server stats. The client stats were being check when the server stats should have been.
steved.