Skip to content

Remove individual I2C commands and cleanup

Jerry Van Baren u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 7 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 7 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot] [PATCH 0/7] Remove individual I2C commands and cleanup
Quoted 22 lines · Heiko Schocher

Hello Peter,

Quoted 6 lines · Peter Tyser

This patch series removes the "individual" I2C commands (and the CONFIG_I2C_CMD_TREE define) and migrates all boards to the newer "tree style" I2C commands.

A small amount of cleanup was performed before and after removing the individual commands.

Thanks for your work, looks good to me. I make some tests with your patches, and if they are OK, I apply your patches to u-boot-i2c.git.

Hmm.. maybe you can have a look at my posting:

http://lists.denx.de/pipermail/u-boot/2009-March/049506.html

There is a new i2c_core.c file which holds all "common" i2c functions, for example the i2c_[set|get]_bus_speed(). I think such a file is a better place for it.

Quoted 8 lines

I wonder I get no response for cleaning up the i2c subsystem ... is here no interest in doing such a cleanup? (I think it is a necessary step ...)

comments are welcome ;-)

bye
Heiko

I am in favor of an i2c cleanup, and also Peter's changeover to the i2c "tree style" fix. I would take the lack of opposition as tacit approval, rather than apathy. Thankfully, the u-boot list isn't made up of a flock of dittoheads (def'n #2):
<http://www.urbandictionary.com/define.php?term=dittohead>

Thanks,
gvb