Skip to content

Remove individual I2C commands and cleanup

Heiko Schocher u-boot 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/20 of 7 patches 0 repliesNew
  2. v2 posting 1/20 of 7 patches 0 repliesSuperseded
  3. v10 of 7 patches 0 repliesSuperseded

Patches in v2 posting 2/2 No applies recorded yet

None of the 7 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [U-Boot] [PATCH v2 0/7] Remove individual I2C commands and cleanup

Hello Peter,

Quoted 17 lines · Heiko Schocher
Quoted 16 lines · Peter Tyser

This patch series removes the "individual" I2C commands (and the CONFIG_I2C_CMD_TREE define) and migrates all boards to the newer "tree style" I2C commands.

A small amount of cleanup was performed before and after removing the individual commands.

Peter Tyser (7):
cm5200: Make function test command names more unique
cmd_i2c: Create common default i2c_[set|get]_bus_speed() functions
cmd_i2c: Remove deprecated individual i2c commands
cmd_i2c: Update references to individual i2c commands
cmd_i2c: Clean up i2c command argument parsing
cmd_i2c: Clean up trivial helper functions
cmd_i2c: Fix i2c help command output when CONFIG_I2C_MUX

Quoted 5 lines
Quoted 2 lines

Changes since v1:
- replaced __attribute references with __attribute__

Applied to u-boot-i2c.git next branch
Thanks!

Damned, I should have wait for the "MAKEALL" is finished ... the nearly two last boards showed me the following error:

Configuring for CPCI750 board...
cmd_i2c.c: In function 'do_i2c':
cmd_i2c.c:1286: error: 'CONFIG_SYS_I2C_SLAVE' undeclared (first use in this function) cmd_i2c.c:1286: error: (Each undeclared identifier is reported only once cmd_i2c.c:1286: error: for each function it appears in.)
make[1]: *** [cmd_i2c.o] Fehler 1
make[1]: *** Warte auf noch nicht beendete Prozesse...
make: *** [common/libcommon.a] Fehler 2
ppc_82xx-size: './u-boot': No such file
Configuring for ELPPC board...
text data bss dec hex filename
169744 19652 38320 227716 37984 ./u-boot
Configuring for p3mx board...
cmd_i2c.c: In function 'do_i2c':
cmd_i2c.c:1286: error: 'CONFIG_SYS_I2C_SLAVE' undeclared (first use in this function) cmd_i2c.c:1286: error: (Each undeclared identifier is reported only once cmd_i2c.c:1286: error: for each function it appears in.)
make[1]: *** [cmd_i2c.o] Fehler 1
make[1]: *** Warte auf noch nicht beendete Prozesse...
make: *** [common/libcommon.a] Fehler 2
ppc_82xx-size: './u-boot': No such file

This is introduced from your patch
[PATCH v2 3/7] i2c: Remove deprecated individual i2c commands from your patchseries ... can you please fix this?

thanks
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany