libosd: Last updates for Linux 2.6.30-rc

Hi dear James, list

I would like to push these 3 patches to support OSD2 revision 5 wire format, for the Linux 2.6.30-rcx series. So to minimize the maintainability headache of having two Kernel versions with two separate wire formats. (Pretending to be OSD2)

I have finally fixed the OSC's osd-target code to support OSD2 up to revision 5, and am able to push these changes to the Linux initiator. (Users will need the new HEAD at osd-target git-tree:
git://git.open-osd.org/osc-osd master)

Revision 5 is suppose to be the very last changes to OSD2 wire format, and is in general frozen state that should only accept fixes to the wording of the text, if any exist.

The very first patch is a BUG fix sent by Dan Carpenter found with "smatch", followed by three patches to fix the wire format for support of revision 5. Only the very last patch actually changes the wire format, the first two only refactor the code in preparation of the actual change.

Here is the list of patches:

[PATCH 1/4] potential ERR_PTR dereference in osd_initiator.c

[PATCH 2/4] libosd: OSD2r05: Prepare for rev5 attribute list changes [PATCH 3/4] libosd: OSD2r05: OSD_CRYPTO_KEYID_SIZE will grow 20 => 32 bytes [PATCH 4/4] libosd: OSD2r05: on-the-wire changes for latest OSD2 draft.

Please see last patch for summery of what changed.

Thanks in advance
Boaz