Skip to content

net: phy: improve phy_driver callback handle_interrupt

Heiner Kallweit netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2net: phy: improve phy_driver callback handle_interruptdrivers/net/phy/mscc/mscc_main.c drivers/net/phy/phy.c include/linux/phy.h+23 -170 replies
2/2net: phy: mscc: consider interrupt source in interrupt handlerdrivers/net/phy/mscc/mscc_main.c+5 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/2] net: phy: improve phy_driver callback handle_interrupt

did_interrupt() clears the interrupt, therefore handle_interrupt() can not check which event triggered the interrupt. To overcome this constraint and allow more flexibility for customer interrupt handlers, let's decouple handle_interrupt() from parts of the phylib interrupt handling. Custom interrupt handlers now have to implement the did_interrupt() functionality in handle_interrupt() if needed.

Fortunately we have just one custom interrupt handler so far (in the mscc PHY driver), convert it to the changed API and make use of the benefits.

Heiner Kallweit (2):
net: phy: improve phy_driver callback handle_interrupt
net: phy: mscc: consider interrupt source in interrupt handler

 drivers/net/phy/mscc/mscc_main.c | 18 ++++++++++++++----
 drivers/net/phy/phy.c            | 26 ++++++++++++--------------
 include/linux/phy.h              |  3 ++-
 3 files changed, 28 insertions(+), 19 deletions(-)
Signature · 1 line
2.25.1