Skip to content

pxa2xx-i2s: Rework

Karl Beldan alsa-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 3 repliesIn review
  2. v14 patches 19 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4pxa2xx-i2s: Proper hw initializationsound/soc/pxa/pxa2xx-i2s.c+0 -02 replies
2/4pxa2xx-i2s: Handle SACR1_DRPL and SACR1_DREC separatelysound/soc/pxa/pxa2xx-i2s.c+0 -00 replies
3/4pxa2xx-i2s: Fix inappropriate release of i2s clocksound/soc/pxa/pxa2xx-i2s.c+0 -00 replies
4/4pxa2xx-i2s: Fix suspend/resumesound/soc/pxa/pxa2xx-i2s.c+0 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH 0/4 v2] pxa2xx-i2s: Rework

Following is a rework of the i2s code for the pxa. I tested it with the ac97 clock as the master clock.

Feedbacks are welcome.

Diff with initial version:

- hw init from 1/4 is moved from pxa2xx_i2s_init to pxa2xx_i2s_probe
- moved 'removal of hw reset from pxa2xx_i2s_startup' from 3/4 to 1/4v2
- moved 'clk_put(clk_i2s) removal' from 2/4 to 3/4v2
- 3/4 was also removing FIFOs flushes, 3/4v2 consists of 'clk_put(clk_i2s) removal' only,

Signature · 1 line
Karl