Skip to content

tracing: seqfile fixes, take 2

Li Zefan lkml 1 version Applied

Status from this message: Applied to tip:tracing/urgent, thanks a lot!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 8 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/7tracing/events: don't increment @pos in s_start()kernel/trace/trace_events.c+22 -61 reply
2/7tracing_bprintk: don't increment @pos in t_start()kernel/trace/trace_printk.c+6 -201 reply
3/7trace_stat: don't increment @pos in seq start()kernel/trace/trace_stat.c+1 -51 reply
4/7tracing: reset iterator in t_start()kernel/trace/trace.c+4 -141 reply
5/7ftrace: don't increment @pos in g_start()kernel/trace/ftrace.c+10 -111 reply
6/7ftrace: don't manipulate @pos in t_start()kernel/trace/ftrace.c+8 -111 reply
7/7ftrace: fix t_hash_start()kernel/trace/ftrace.c+11 -11 reply

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchLiming Wang
1/7R-b R-b
2/7R-b R-b
3/7R-b R-b
4/7R-b R-b
5/7R-b R-b
6/7R-b R-b
7/7R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] tracing: seqfile fixes, take 2

While testing syscall tracepoints proposed by Jason, I found some entries were missing when reading available_events.

It turned out there's bug in seqfile handling. The bug is, it's wrong to increment @pos in seq start().

The bug exists in some other places. I also fixed some other different bugs.

All the patches have been reviewed and tested.

Thanks Liming Wang for the review.

[PATCH 1/7] tracing/events: don't increment @pos in s_start() [PATCH 2/7] tracing_bprintk: don't increment @pos in t_start() [PATCH 3/7] trace_stat: don't increment @pos in seq start() [PATCH 4/7] tracing: reset iterator in t_start() [PATCH 5/7] ftrace: don't increment @pos in g_start() [PATCH 6/7] ftrace: don't manipulate @pos in t_start() [PATCH 7/7] ftrace: fix t_hash_start()

---
 kernel/trace/ftrace.c       |   52 ++++++++++++++++++++++++-------------------
 kernel/trace/trace.c        |   18 +++-----------
 kernel/trace/trace_events.c |   28 ++++++++++++++++++-----
 kernel/trace/trace_printk.c |   26 +++++----------------
 kernel/trace/trace_stat.c   |    6 +----
 5 files changed, 62 insertions(+), 68 deletions(-)